diff options
| author | Aaron Lu <aaron.lu@intel.com> | 2018-05-24 10:49:28 +0800 |
|---|---|---|
| committer | Fengguang Wu <fengguang.wu@intel.com> | 2018-05-24 11:15:01 +0800 |
| commit | 7afdeab54a58825ba346ad83615afd1ac105c1b0 (patch) | |
| tree | 9754d41d220382751a4db836bf16f671ffb655f4 | |
| parent | 5a31b990bf0265e6faddea15216a169515a4781a (diff) | |
| download | vm-scalability-7afdeab54a58825ba346ad83615afd1ac105c1b0.tar.gz | |
small-allocs-common: update naming
On Mon, Apr 02, 2018 at 12:37:36PM +0800, Fengguang Wu wrote:
> On Mon, Apr 02, 2018 at 12:26:47PM +0800, Aaron Lu wrote:
> > On Mon, 2018-04-02 at 12:19 +0800, Fengguang Wu wrote:
> > > > case-small-allocs | 20 +-------------------
> > > > case-small-allocs-common | 21 +++++++++++++++++++++
> > > > case-small-allocs-mt | 7 ++-----
> > >
> > > Applied. It may be better to rename the -common script
> > > so that case-* won't match it -- it's not a real test case,
> > > after all. Do you have a better file name in mind?
> >
> > What about removing the case prefix and name it as small-allocs-common?
>
> OK, I just renamed the file and deployed.
Turnes out there are other places need updating too to reflect the
file's name change.
From f3369cb9e8e594b55946ac54c5ab6a7efe703faf Mon Sep 17 00:00:00 2001
From: Aaron Lu <aaron.lu@intel.com>
Date: Thu, 24 May 2018 10:39:46 +0800
Subject: [PATCH] small-allocs-common: fix mis naming
I used to name the common file as case-small-allocs-common but
decided to use the name of small-allocs-common in the end after
talking to Fengguang. The file is renamed but other scripts that
call it didn't see the update so this patch fix it or an error:
stderr: ./case-small-allocs-mt: 3: .: Can't open ./case-small-allocs-common
would occur.
Reported-by: Hailin Gu <hailinx.gu@intel.com>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
| -rwxr-xr-x | case-small-allocs | 2 | ||||
| -rwxr-xr-x | case-small-allocs-mt | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/case-small-allocs b/case-small-allocs index 688c17c..78046f9 100755 --- a/case-small-allocs +++ b/case-small-allocs @@ -1,5 +1,5 @@ #!/bin/sh -. ./case-small-allocs-common +. ./small-allocs-common $USEMEM -n $nr_task --readonly --unit $unit_size $((size / nr_task)) diff --git a/case-small-allocs-mt b/case-small-allocs-mt index e3d96a7..ab8ce97 100755 --- a/case-small-allocs-mt +++ b/case-small-allocs-mt @@ -1,5 +1,5 @@ #!/bin/sh -. ./case-small-allocs-common +. ./small-allocs-common $USEMEM -t $nr_task --readonly --unit $((10 * pagesize)) $((size / nr_task)) |