diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-05-18 14:29:55 +0300 |
|---|---|---|
| committer | Lucas Stach <l.stach@pengutronix.de> | 2020-05-19 11:18:59 +0200 |
| commit | ad99cb5e783bb03d512092db3387ead9504aad3d (patch) | |
| tree | 828e72ce6d9ac2f5fad4ca0190c0eba6f93be0c0 | |
| parent | 40b697e256ccdb88aaff424b44b4d300eb8460e8 (diff) | |
| download | dma-buf-ad99cb5e783bb03d512092db3387ead9504aad3d.tar.gz | |
drm/etnaviv: Fix a leak in submit_pin_objects()
If the mapping address is wrong then we have to release the reference to
it before returning -EINVAL.
Fixes: 088880ddc0b2 ("drm/etnaviv: implement softpin")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
| -rw-r--r-- | drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index 3b0afa156d9299..54def341c1dbe7 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -238,8 +238,10 @@ static int submit_pin_objects(struct etnaviv_gem_submit *submit) } if ((submit->flags & ETNA_SUBMIT_SOFTPIN) && - submit->bos[i].va != mapping->iova) + submit->bos[i].va != mapping->iova) { + etnaviv_gem_mapping_unreference(mapping); return -EINVAL; + } atomic_inc(&etnaviv_obj->gpu_active); |