summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMateusz Kusiak <mateusz.kusiak@intel.com>2022-05-19 09:16:08 +0200
committerJes Sorensen <jsorensen@fb.com>2022-06-09 18:13:11 -0400
commit20e114e334ed6ed3280c37a9a08fb95578393d1a (patch)
treec00ac788c93fbbbc9c140ce784ffe4e6308bfb70
parent1066ab83dbe9a4cc20f7db44a40aa2cbb9d5eed6 (diff)
downloadmdadm-20e114e334ed6ed3280c37a9a08fb95578393d1a.tar.gz
Grow: block -n on external volumes.
Performing --raid-devices on external metadata volume should be blocked as it causes unwanted behaviour. Eg. Performing mdadm -G /dev/md/volume -l10 -n4 on r0_d2 inside 4 disk container, returns mdadm: Need 2 spares to avoid degraded array, only have 0. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
-rw-r--r--Grow.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/Grow.c b/Grow.c
index 8a242b0f..f6efbc48 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1892,6 +1892,14 @@ int Grow_reshape(char *devname, int fd,
if (retval) {
pr_err("Cannot read superblock for %s\n", devname);
+ close(cfd);
+ free(subarray);
+ return 1;
+ }
+
+ if (s->raiddisks && subarray) {
+ pr_err("--raid-devices operation can be performed on a container only\n");
+ close(cfd);
free(subarray);
return 1;
}