diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2023-09-12 23:29:10 +0900 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-09-13 10:21:05 -0500 |
| commit | 59d8d24f4610333560cf2e8fe3f44cafe30322eb (patch) | |
| tree | 9b676b09360b8aab99f4faa63eebd775dc023023 | |
| parent | e4e14095cc68a2efefba6f77d95efe1137e751d4 (diff) | |
| download | linux-59d8d24f4610333560cf2e8fe3f44cafe30322eb.tar.gz | |
ksmbd: fix passing freed memory 'aux_payload_buf'
The patch e2b76ab8b5c9: "ksmbd: add support for read compound" leads
to the following Smatch static checker warning:
fs/smb/server/smb2pdu.c:6329 smb2_read()
warn: passing freed memory 'aux_payload_buf'
It doesn't matter that we're passing a freed variable because nbytes is
zero. This patch set "aux_payload_buf = NULL" to make smatch silence.
Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/server/smb2pdu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 749660110878fd..544022dd6d2007 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6312,7 +6312,7 @@ int smb2_read(struct ksmbd_work *work) aux_payload_buf, nbytes); kvfree(aux_payload_buf); - + aux_payload_buf = NULL; nbytes = 0; if (remain_bytes < 0) { err = (int)remain_bytes; |