aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkernel test robot <lkp@intel.com>2021-03-28 16:54:45 +0200
committerMark Brown <broonie@kernel.org>2021-03-29 17:27:22 +0100
commitaa320c7cd45647b75af2233430d36a8d154703d4 (patch)
treeebd03ad394d808d3e9de5da0b474533934e8d87d
parent3a27875e91fb9c29de436199d20b33f9413aea77 (diff)
downloadkernfs-aa320c7cd45647b75af2233430d36a8d154703d4.tar.gz
ASoC: cygnus: fix for_each_child.cocci warnings
Function "for_each_available_child_of_node" should have of_node_put() before return around line 1352. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Sumera Priyadarsini <sylphrenadin@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2103281651320.2854@hadrien Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/bcm/cygnus-ssp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c
index 6e634b4482930..aa16a23751346 100644
--- a/sound/soc/bcm/cygnus-ssp.c
+++ b/sound/soc/bcm/cygnus-ssp.c
@@ -1348,8 +1348,10 @@ static int cygnus_ssp_probe(struct platform_device *pdev)
&cygnus_ssp_dai[active_port_count]);
/* negative is err, 0 is active and good, 1 is disabled */
- if (err < 0)
+ if (err < 0) {
+ of_node_put(child_node);
return err;
+ }
else if (!err) {
dev_dbg(dev, "Activating DAI: %s\n",
cygnus_ssp_dai[active_port_count].name);