diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-04-15 18:46:23 +0300 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2022-04-19 11:31:31 +0200 |
commit | 0a218c7b7fa3628bead8f78900131f4ef4f784b2 (patch) | |
tree | 19410f8b916d8ee9c30cbf7fb93f56e10049d5ea | |
parent | 5990a4774b53e53f42b07e28574bbda6ff144ac2 (diff) | |
download | net-next-0a218c7b7fa3628bead8f78900131f4ef4f784b2.tar.gz |
net: dsa: use dsa_tree_for_each_user_port in dsa_slave_change_mtu
Use the more conventional iterator over user ports instead of explicitly
ignoring them, and use the more conventional name "other_dp" instead of
"dp_iter", for readability.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
-rw-r--r-- | net/dsa/slave.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 41c69a6e7854a..da234c4b7daad 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1808,7 +1808,7 @@ int dsa_slave_change_mtu(struct net_device *dev, int new_mtu) struct dsa_port *dp = dsa_slave_to_port(dev); struct dsa_slave_priv *p = netdev_priv(dev); struct dsa_switch *ds = p->dp->ds; - struct dsa_port *dp_iter; + struct dsa_port *other_dp; struct dsa_port *cpu_dp; int port = p->dp->index; int largest_mtu = 0; @@ -1821,26 +1821,23 @@ int dsa_slave_change_mtu(struct net_device *dev, int new_mtu) if (!ds->ops->port_change_mtu) return -EOPNOTSUPP; - list_for_each_entry(dp_iter, &ds->dst->ports, list) { + dsa_tree_for_each_user_port(other_dp, ds->dst) { int slave_mtu; - if (!dsa_port_is_user(dp_iter)) - continue; - /* During probe, this function will be called for each slave * device, while not all of them have been allocated. That's * ok, it doesn't change what the maximum is, so ignore it. */ - if (!dp_iter->slave) + if (!other_dp->slave) continue; /* Pretend that we already applied the setting, which we * actually haven't (still haven't done all integrity checks) */ - if (dp_iter == dp) + if (dp == other_dp) slave_mtu = new_mtu; else - slave_mtu = dp_iter->slave->mtu; + slave_mtu = other_dp->slave->mtu; if (largest_mtu < slave_mtu) largest_mtu = slave_mtu; |