diff options
| author | Jacob Keller <jacob.e.keller@intel.com> | 2020-07-27 15:49:37 -0700 |
|---|---|---|
| committer | Michal Kubecek <mkubecek@suse.cz> | 2020-07-30 12:15:07 +0200 |
| commit | c5e85d6d972defd262e01f8a9bee5b88ee47a760 (patch) | |
| tree | 7b9a2fce757ad5ccb4f7031484654bf9019b4ac5 | |
| parent | 11aa21adf905d1eb966b1dcf32996110eb94221c (diff) | |
| download | ethtool-c5e85d6d972defd262e01f8a9bee5b88ee47a760.tar.gz | |
ethtool: use "Not reported" when no FEC modes are provided
When displaying the FEC link modes advertised by the peer, we used the
string "No" to indicate when nothing was provided. This does not match
the IOCTL output which indicates "Not reported". It also doesn't match
the local advertised FEC modes, which also used the "Not reported"
string.
This is especially confusing for FEC, because the FEC bits include
a "None" bit which indicates that FEC is definitely not supported. Avoid
this confusion and match both the local advertised settings display and
the old IOCTL output by using "Not reported" when FEC settings aren't
reported.
Fixes: 10cc3ea337d1 ("netlink: partial netlink handler for gset (no option)")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
| -rw-r--r-- | netlink/settings.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/netlink/settings.c b/netlink/settings.c index 66b0d48..726259d 100644 --- a/netlink/settings.c +++ b/netlink/settings.c @@ -481,7 +481,7 @@ static int dump_peer_modes(struct nl_context *nlctx, const struct nlattr *attr) ret = dump_link_modes(nlctx, attr, false, LM_CLASS_FEC, "Link partner advertised FEC modes: ", - " ", "\n", "No"); + " ", "\n", "Not reported"); return ret; } |