diff options
| author | Eric Sandeen <sandeen@redhat.com> | 2018-11-30 07:55:57 -0800 |
|---|---|---|
| committer | Luis Chamberlain <mcgrof@kernel.org> | 2019-01-30 14:47:31 -0800 |
| commit | fae286b39a9d49f16d02cb4b12f3e11b12cb31ca (patch) | |
| tree | e7e57a2bf4cc65ae9d3f0746568bf271ba68b4c0 | |
| parent | e27aec3a0f77e0da7745c1bba16657bb4caea215 (diff) | |
| download | linux-stable-linux-xfs-4.19.y.tar.gz | |
xfs: fix inverted return from xfs_btree_sblock_verify_crclinux-xfs-4.19.y
xfs_btree_sblock_verify_crc is a bool so should not be returning
a failaddr_t; worse, if xfs_log_check_lsn fails it returns
__this_address which looks like a boolean true (i.e. success)
to the caller.
(interestingly xfs_btree_lblock_verify_crc doesn't have the issue)
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
| -rw-r--r-- | fs/xfs/libxfs/xfs_btree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c index 34c6d7bd4d180..bbdae2b4559fc 100644 --- a/fs/xfs/libxfs/xfs_btree.c +++ b/fs/xfs/libxfs/xfs_btree.c @@ -330,7 +330,7 @@ xfs_btree_sblock_verify_crc( if (xfs_sb_version_hascrc(&mp->m_sb)) { if (!xfs_log_check_lsn(mp, be64_to_cpu(block->bb_u.s.bb_lsn))) - return __this_address; + return false; return xfs_buf_verify_cksum(bp, XFS_BTREE_SBLOCK_CRC_OFF); } |