diff options
| author | Mike Snitzer <snitzer@kernel.org> | 2023-06-13 20:05:34 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@kernel.org> | 2023-06-15 12:46:59 -0400 |
| commit | 722d90822321497e2837cfc9000202e256e6b32f (patch) | |
| tree | ba57e0acdb653334c3ace1a5be99daeecbe2b2ce | |
| parent | cb65b282c9640c27d3129e2e04b711ce1b352838 (diff) | |
| download | linux-722d90822321497e2837cfc9000202e256e6b32f.tar.gz | |
dm thin: fix issue_discard to pass GFP_NOIO to __blkdev_issue_discard
issue_discard() passes GFP_NOWAIT to __blkdev_issue_discard() despite
its code assuming bio_alloc() always succeeds.
Commit 3dba53a958a75 ("dm thin: use __blkdev_issue_discard for async
discard support") clearly shows where things went bad:
Before commit 3dba53a958a75, dm-thin.c's open-coded
__blkdev_issue_discard_async() properly handled using GFP_NOWAIT.
Unfortunately __blkdev_issue_discard() doesn't and it was missed
during review.
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
| -rw-r--r-- | drivers/md/dm-thin.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 2b13c949bd726b..39410bf186cf6e 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -401,8 +401,7 @@ static int issue_discard(struct discard_op *op, dm_block_t data_b, dm_block_t da sector_t s = block_to_sectors(tc->pool, data_b); sector_t len = block_to_sectors(tc->pool, data_e - data_b); - return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOWAIT, - &op->bio); + return __blkdev_issue_discard(tc->pool_dev->bdev, s, len, GFP_NOIO, &op->bio); } static void end_discard(struct discard_op *op, int r) |