diff options
| author | Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> | 2018-07-24 16:51:38 +0200 |
|---|---|---|
| committer | Simon Horman <horms+renesas@verge.net.au> | 2018-09-28 14:42:13 +0200 |
| commit | 2a2a48e9abb6ded92f9fb2b3e8fdf5d7a929e05b (patch) | |
| tree | 6cce46cc1b6bf908a5f1939298c282f0b87eae3f | |
| parent | d094932c868816df3a231e22b5f2bf91c9595c71 (diff) | |
| download | renesas-backport-backport/v4.14.61/snapshot-flattened.tar.gz | |
mmc: renesas_sdhi: Fix sampling clock position selectingHEADbackport/v4.14.61/snapshot-to-v4.18+fixes-v3-flattenedmasterbackport/v4.14.61/snapshot-flattened
When tuning each tap is issued CMD19 twice and the result of both runs
recorded in host->taps. If the result is different between the two runs
the wrong sampling clock position was selected. Fix this by merging the
two runs and only keep the result for each tap if it was good in both
sets.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
(cherry picked from commit 5c99826b27d0afd4c05c2013385b17037f579cf9)
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
| -rw-r--r-- | drivers/mmc/host/renesas_sdhi_core.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 45c015da2e757..f087ac728e35b 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -302,6 +302,18 @@ static int renesas_sdhi_select_tuning(struct tmio_mmc_host *host) sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_RVSREQ, 0); /* + * When tuning CMD19 is issued twice for each tap, merge the + * result requiring the tap to be good in both runs before + * considering it for tuning selection. + */ + for (i = 0; i < host->tap_num * 2; i++) { + int offset = host->tap_num * (i < host->tap_num ? 1 : -1); + + if (!test_bit(i, host->taps)) + clear_bit(i + offset, host->taps); + } + + /* * Find the longest consecutive run of successful probes. If that * is more than SH_MOBILE_SDHI_MAX_TAP probes long then use the * center index as the tap. |