aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortaebum81.kim <taebum81.kim@lge.com>2018-11-05 15:43:37 +0900
committerJaegeuk Kim <jaegeuk@kernel.org>2018-11-21 11:38:23 -0800
commit946d8f458345d59c5b5f7849302706fd46893718 (patch)
treef1fb68c6cba573801ee3c3e3d24eafd3903dc1dd
parent7dfb93ff362d75801b8c989441a6fa3cab84fecb (diff)
downloadf2fs-tools-946d8f458345d59c5b5f7849302706fd46893718.tar.gz
sload.f2fs: fix memory leak
Dynamic memory stored in 'xattr_node' allocated through function 'calloc' at line 98 can be lost at line 111 Dynamic memory stored in 'inode' allocated through function 'calloc' at line 144 can be lost at line 227 Signed-off-by: taebum81.kim <taebum81.kim@lge.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r--fsck/xattr.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fsck/xattr.c b/fsck/xattr.c
index 1d15d1b..b13e5ee 100644
--- a/fsck/xattr.c
+++ b/fsck/xattr.c
@@ -108,6 +108,9 @@ static void write_all_xattrs(struct f2fs_sb_info *sbi,
ret = dev_write_block(xattr_node, blkaddr);
ASSERT(ret >= 0);
+
+ if (xnid)
+ free(xattr_node);
}
int f2fs_setxattr(struct f2fs_sb_info *sbi, nid_t ino, int index, const char *name,
@@ -223,6 +226,7 @@ int f2fs_setxattr(struct f2fs_sb_info *sbi, nid_t ino, int index, const char *na
ret = dev_write_block(inode, ni.blk_addr);
ASSERT(ret >= 0);
exit:
+ free(inode);
free(base_addr);
return error;
}