diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-21 09:07:34 -0700 |
|---|---|---|
| committer | Eryu Guan <guaneryu@gmail.com> | 2018-05-22 11:03:49 +0800 |
| commit | 954f28239b4c74e7b234f8473ee640c306d7b169 (patch) | |
| tree | d98bc54adfed0c4d7f948f860328d6c0c40ea944 | |
| parent | 78f713a198eda619c4255bce6a95e5a8e93d85bb (diff) | |
| download | xfstests-dev-954f28239b4c74e7b234f8473ee640c306d7b169.tar.gz | |
generic/475: fix confusing comment
The comment about the dmerror switcheroo is hard to understand and
wrong. Fix both problems by rewriting it.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
| -rwxr-xr-x | tests/generic/475 | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/tests/generic/475 b/tests/generic/475 index e31f1251c5..4507227841 100755 --- a/tests/generic/475 +++ b/tests/generic/475 @@ -73,9 +73,11 @@ for i in $(seq 1 $((50 * TIME_FACTOR)) ); do # recovery sleep $((RANDOM % 3)) - # Loading error table without "--nolockfs" option. Because "--nolockfs" - # won't freeze fs, then some running I/Os may cause XFS to shutdown - # prematurely. That's not what we want to test. + # This test aims to simulate sudden disk failure, which means that we + # do not want to quiesce the filesystem or otherwise give it a chance + # to flush its logs. Therefore we want to call dmsetup with the + # --nolockfs parameter; to make this happen we must call the load + # error table helper *without* 'lockfs'. _dmerror_load_error_table ps -e | grep fsstress > /dev/null 2>&1 |