diff options
| author | Ritesh Harjani <riteshh@linux.ibm.com> | 2022-01-17 17:41:48 +0530 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2022-02-03 10:57:30 -0500 |
| commit | 09355d9d038a1590ee055831a4ad3a79952cfa8b (patch) | |
| tree | cdad6d3a563cfafd57355e2a8f65564b29d07555 | |
| parent | 897026aaa73eb2517dfea8d147f20ddb0b813044 (diff) | |
| download | linux-dm-09355d9d038a1590ee055831a4ad3a79952cfa8b.tar.gz | |
ext4: remove redundant max inline_size check in ext4_da_write_inline_data_begin()
ext4_prepare_inline_data() already checks for ext4_get_max_inline_size()
and returns -ENOSPC. So there is no need to check it twice within
ext4_da_write_inline_data_begin(). This patch removes the extra check.
It also makes it more clean.
No functionality change in this patch.
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/cdd1654128d5105550c65fd13ca5da53b2162cc4.1642416995.git.riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/inline.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index d091133a4b460..cbdd84e49f2c6 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -911,7 +911,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping, struct page **pagep, void **fsdata) { - int ret, inline_size; + int ret; handle_t *handle; struct page *page; struct ext4_iloc iloc; @@ -928,14 +928,9 @@ retry_journal: goto out; } - inline_size = ext4_get_max_inline_size(inode); - - ret = -ENOSPC; - if (inline_size >= pos + len) { - ret = ext4_prepare_inline_data(handle, inode, pos + len); - if (ret && ret != -ENOSPC) - goto out_journal; - } + ret = ext4_prepare_inline_data(handle, inode, pos + len); + if (ret && ret != -ENOSPC) + goto out_journal; /* * We cannot recurse into the filesystem as the transaction |