aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2019-11-20 19:19:07 -0800
committerBen Hutchings <ben@decadent.org.uk>2020-06-11 19:05:37 +0100
commit6b07736e72bc1546400d085485d92c256408c5ea (patch)
tree2dc09d5a830672342910931fab5ecb54c4202851
parent3bae3560840ee30c9f2262b69196ba4dbc6086f6 (diff)
downloadlinux-stable-6b07736e72bc1546400d085485d92c256408c5ea.tar.gz
net-sysfs: fix netdev_queue_add_kobject() breakage
commit 48a322b6f9965b2f1e4ce81af972f0e287b07ed0 upstream. kobject_put() should only be called in error path. Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Jouni Hogander <jouni.hogander@unikie.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--net/core/net-sysfs.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index dc09fbff28b7d5..65019647f72ae5 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1158,6 +1158,7 @@ static int netdev_queue_add_kobject(struct net_device *net, int index)
#endif
kobject_uevent(kobj, KOBJ_ADD);
+ return 0;
err:
kobject_put(kobj);