aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSun Ke <sunke32@huawei.com>2022-02-08 15:16:24 +0800
committerEryu Guan <guaneryu@gmail.com>2022-02-21 00:01:07 +0800
commiteb564a21879912c842a522aedef0fac6d922a467 (patch)
tree0f0d5fb98a4bcb19ae9f023d8726a71137af9a8d
parent11342071e1054c65a28d32f3c6ab63c4bd6ef5a6 (diff)
downloadxfstests-dev-eb564a21879912c842a522aedef0fac6d922a467.tar.gz
common/attr: adbjust acl_max of f2fs
f2fs has set inline_xattr as a default option, and introduced a new option named 'noinline_xattr' for disabling default inline_xattr option. So in _acl_get_max we need to check 'noinline_xattr' string in fs option, otherwise we may select the wrong max acl number since we always found the string 'inline_xattr' in fs option. Additionally, f2fs has changed disk layout of xattr block a bit, so will contain one more entry in both inline and noinline xattr inode, this patch will modify the max acl number to adjust it. Suggested-by: Chao Yu <chao@kernel.org> Signed-off-by: Sun Ke <sunke32@huawei.com> Reviewed-by: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
-rw-r--r--common/attr19
1 files changed, 16 insertions, 3 deletions
diff --git a/common/attr b/common/attr
index 35682d7c56..dae8a1bb08 100644
--- a/common/attr
+++ b/common/attr
@@ -26,11 +26,24 @@ _acl_get_max()
echo 8191
;;
f2fs)
- _fs_options $TEST_DEV | grep "inline_xattr" >/dev/null 2>&1
+ # If noinline_xattr is enabled, max xattr size should be:
+ # (4096 - 24) - (24 + 4) = 4044
+ # then ACL_MAX_ENTRIES should be:
+ # (4044 - (4 + 4 * 4)) / 8 + 4 = 507
+ _fs_options $TEST_DEV | grep "noinline_xattr" >/dev/null 2>&1
if [ $? -eq 0 ]; then
- echo 531
+ echo 507
else
- echo 506
+ # If inline_xattr is enabled, max xattr size should be:
+ # (4096 - 24 + 200) - (24 + 4) = 4244
+ # then ACL_MAX_ENTRIES should be:
+ # (4244 - (4 + 4 * 4)) / 8 + 4 = 532
+ _fs_options $TEST_DEV | grep "inline_xattr" >/dev/null 2>&1
+ if [ $? -eq 0 ]; then
+ echo 532
+ else
+ echo 507
+ fi
fi
;;
bcachefs)