diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2018-06-07 16:29:48 +0200 |
|---|---|---|
| committer | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2018-08-07 17:37:16 +0200 |
| commit | 3d23b6f76d14fe57655131dff416fc88415c081f (patch) | |
| tree | f8784e0ed24492a807a7b92c0178299dd5ec592c | |
| parent | 0696becf20ab3047ae6e0031c65a66884aa97f29 (diff) | |
| download | staging-usb-iso.tar.gz | |
usb: host: ehci: use usb_fill_control_urb()usb-iso
Using usb_fill_control_urb() helps to find code which initializes an
URB. A grep for members of the struct (like ->complete) reveal lots
of other things, too.
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
| -rw-r--r-- | drivers/usb/host/ehci-hub.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index d7641cbdee43d..3f83fd974447c 100644 --- a/drivers/usb/host/ehci-hub.c +++ b/drivers/usb/host/ehci-hub.c @@ -753,7 +753,6 @@ static struct urb *request_single_step_set_feature_urb( if (!urb) return NULL; - urb->pipe = usb_rcvctrlpipe(udev, 0); ep = (usb_pipein(urb->pipe) ? udev->ep_in : udev->ep_out) [usb_pipeendpoint(urb->pipe)]; if (!ep) { @@ -761,14 +760,12 @@ static struct urb *request_single_step_set_feature_urb( return NULL; } + usb_fill_control_urb(urb, udev, usb_rcvctrlpipe(udev, 0), + dr, buf, USB_DT_DEVICE_SIZE, usb_ehset_completion, + done); + urb->ep = ep; - urb->dev = udev; - urb->setup_packet = (void *)dr; - urb->transfer_buffer = buf; - urb->transfer_buffer_length = USB_DT_DEVICE_SIZE; - urb->complete = usb_ehset_completion; urb->status = -EINPROGRESS; - urb->actual_length = 0; urb->transfer_flags = URB_DIR_IN; usb_get_urb(urb); atomic_inc(&urb->use_count); @@ -783,7 +780,6 @@ static struct urb *request_single_step_set_feature_urb( urb->transfer_buffer, urb->transfer_buffer_length, DMA_FROM_DEVICE); - urb->context = done; return urb; } |