aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorDouglas Anderson <dianders@chromium.org>2023-10-20 14:06:55 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-11-08 17:26:39 +0100
commit83cfa3b51a789f8791df03b48cb87cd21c98acf0 (patch)
tree6d745091cdde1669fcded5239855c094e5288b91
parente0f9231ccd6cf512bddde0ebdaa11c0d9958bc24 (diff)
downloadaa-83cfa3b51a789f8791df03b48cb87cd21c98acf0.tar.gz
r8152: Release firmware if we have an error in probe
[ Upstream commit b8d35024d4059ca550cba11ac9ab23a6c238d929 ] The error handling in rtl8152_probe() is missing a call to release firmware. Add it in to match what's in the cleanup code in rtl8152_disconnect(). Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153") Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/usb/r8152.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index baa3c57d16427d..f6d5fbb9dee07e 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9802,6 +9802,7 @@ out1:
cancel_delayed_work_sync(&tp->hw_phy_work);
if (tp->rtl_ops.unload)
tp->rtl_ops.unload(tp);
+ rtl8152_release_firmware(tp);
usb_set_intfdata(intf, NULL);
out:
free_netdev(netdev);