diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-16 14:50:25 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-12-08 15:40:19 +0100 |
| commit | d815b3f2f273537cb8afaf5ab11a46851f6c03e5 (patch) | |
| tree | 07696c1757f62c1b5b4b208bae0a72b75b145890 | |
| parent | daf87e953527b03c0bd4c0f41d704ba71186256d (diff) | |
| download | linux-misc-d815b3f2f273537cb8afaf5ab11a46851f6c03e5.tar.gz | |
btrfs: fix error pointer dereference in btrfs_ioctl_rm_dev_v2()
If memdup_user() fails the error handing will crash when it tries
to kfree() an error pointer. Just return directly because there is
no cleanup required.
Fixes: 1a15eb724aae ("btrfs: use btrfs_get_dev_args_from_path in dev removal ioctls")
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/ioctl.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 012fbfdfbebf2..1b85d98df66be 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3188,10 +3188,8 @@ static long btrfs_ioctl_rm_dev_v2(struct file *file, void __user *arg) return -EPERM; vol_args = memdup_user(arg, sizeof(*vol_args)); - if (IS_ERR(vol_args)) { - ret = PTR_ERR(vol_args); - goto out; - } + if (IS_ERR(vol_args)) + return PTR_ERR(vol_args); if (vol_args->flags & ~BTRFS_DEVICE_REMOVE_ARGS_MASK) { ret = -EOPNOTSUPP; |