diff options
| author | Nikolay Borisov <nborisov@suse.com> | 2021-02-23 15:20:42 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-03-02 16:55:44 +0100 |
| commit | 4f6a49de64fd1b1dba5229c02047376da7cf24fd (patch) | |
| tree | 7c8b4302b77b5d964d8ed9d740c6456aaca04bd3 | |
| parent | aedb9d9089ceb1c86be495bcc70e6021c01f92ff (diff) | |
| download | linux-4f6a49de64fd1b1dba5229c02047376da7cf24fd.tar.gz | |
btrfs: unlock extents in btrfs_zero_range in case of quota reservation errors
If btrfs_qgroup_reserve_data returns an error (i.e quota limit reached)
the handling logic directly goes to the 'out' label without first
unlocking the extent range between lockstart, lockend. This results in
deadlocks as other processes try to lock the same extent.
Fixes: a7f8b1c2ac21 ("btrfs: file: reserve qgroup space after the hole punch range is locked")
CC: stable@vger.kernel.org # 5.10+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/file.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 01a72f53fb5dd2..2c282664c4b843 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -3260,8 +3260,11 @@ reserve_space: goto out; ret = btrfs_qgroup_reserve_data(BTRFS_I(inode), &data_reserved, alloc_start, bytes_to_reserve); - if (ret) + if (ret) { + unlock_extent_cached(&BTRFS_I(inode)->io_tree, lockstart, + lockend, &cached_state); goto out; + } ret = btrfs_prealloc_file_range(inode, mode, alloc_start, alloc_end - alloc_start, i_blocksize(inode), |