diff options
| author | Glenn Washburn <development@efficientek.com> | 2022-05-11 21:44:01 -0500 |
|---|---|---|
| committer | Daniel Kiper <daniel.kiper@oracle.com> | 2022-05-24 14:37:24 +0200 |
| commit | ad019a107a17460620374b1fc29b78884153fdb8 (patch) | |
| tree | a99369f350fd1aa509b964f5703279887079504d | |
| parent | 3efd7912d9f8bedf1f46b0ebe4d80d976f62edfb (diff) | |
| download | grub-ad019a107a17460620374b1fc29b78884153fdb8.tar.gz | |
net/net: Fix incorrect condition for calling grub_net_tcp_retransmit()
The commit 848724273e4 (net/net: Avoid unnecessary calls to
grub_net_tcp_retransmit()) needs to have its condition inverted to avoid
unnecessary calls to grub_net_tcp_retransmit(). As it is, it creates many
unnecessary calls and does not call grub_net_tcp_retransmit() when needed.
The call to grub_net_tcp_retransmit() should only be made when
grub_net_cards does _not_ equal NULL, meaning that there are potentially
network cards that need TCP retransmission.
Fixes: 848724273e4 (net/net: Avoid unnecessary calls to grub_net_tcp_retransmit())
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
| -rw-r--r-- | grub-core/net/net.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/grub-core/net/net.c b/grub-core/net/net.c index 88ea49fee..2b6771523 100644 --- a/grub-core/net/net.c +++ b/grub-core/net/net.c @@ -1634,7 +1634,7 @@ grub_net_poll_cards_idle_real (void) || ctime >= card->last_poll + card->idle_poll_delay_ms) receive_packets (card, 0); } - if (grub_net_cards == NULL) + if (grub_net_cards != NULL) grub_net_tcp_retransmit (); } |