diff options
| author | Alec Brown <alec.r.brown@oracle.com> | 2022-03-21 02:28:57 -0400 |
|---|---|---|
| committer | Daniel Kiper <daniel.kiper@oracle.com> | 2022-04-04 20:28:54 +0200 |
| commit | 261e4511ce335cc3784cbbe6c99fd35a81efa059 (patch) | |
| tree | 7e5adce023064bcae0f31ef00d442aa8cf6786a4 | |
| parent | c0272c12b6c895de21f88cbb6387cdec04ff48a5 (diff) | |
| download | grub-261e4511ce335cc3784cbbe6c99fd35a81efa059.tar.gz | |
loader/i386/pc/linux: Fix uninitialized scalar variable
In the function grub_linux16_boot(), struct grub_relocator16_state state is
called but isn't being initialized. This results in the members grub_uint32_t
ebx, grub_uint32_t edx, grub_uint32_t esi, and grub_uint32_t ebp being filled
with junk data from the stack since none of them are being set to any values.
We can prevent this by setting state to {0}.
Fixes: CID 375028
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
| -rw-r--r-- | grub-core/loader/i386/pc/linux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/grub-core/loader/i386/pc/linux.c b/grub-core/loader/i386/pc/linux.c index b670b6532..7b89d4310 100644 --- a/grub-core/loader/i386/pc/linux.c +++ b/grub-core/loader/i386/pc/linux.c @@ -55,7 +55,7 @@ static grub_err_t grub_linux16_boot (void) { grub_uint16_t segment; - struct grub_relocator16_state state; + struct grub_relocator16_state state = {0}; segment = grub_linux_real_target >> 4; state.gs = state.fs = state.es = state.ds = state.ss = segment; |