share/: $CFLAGS: Add -Werror

Most of the time, we want to build with -Werror.  Not having it in the
default $CFLAGS is error-prone.

Distributions can pass EXTRA_CFLAGS=-Wno-error to avoid unnecessary
build errors.

Signed-off-by: Alejandro Colomar <alx@kernel.org>

27 files changed, 1 insertions, 26 deletions

diff --git a/share/mk/configure/cc.mk b/share/mk/configure/cc.mk
index 345ad81..093b0f9 100644
--- a/share/mk/configure/cc.mk
+++ b/share/mk/configure/cc.mk
@@ -52,6 +52,7 @@ CLANG_CFLAGS += -Wno-unused-macros
 DEFAULT_CFLAGS := -O3
 DEFAULT_CFLAGS += -Wall
 DEFAULT_CFLAGS += -Wextra
+DEFAULT_CFLAGS += -Werror
 DEFAULT_CFLAGS += -Wstrict-prototypes
 DEFAULT_CFLAGS += -Wdeclaration-after-statement
 DEFAULT_CFLAGS += -Wno-unknown-pragmas
diff --git a/share/tests/a2i.h/a2i/a2i_nobuild.sh b/share/tests/a2i.h/a2i/a2i_nobuild.sh
index 0810002..3fbafce 100755
--- a/share/tests/a2i.h/a2i/a2i_nobuild.sh
+++ b/share/tests/a2i.h/a2i/a2i_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2s/a2s_nobuild.sh b/share/tests/a2i.h/a2s/a2s_nobuild.sh
index 710577c..0c8a468 100755
--- a/share/tests/a2i.h/a2s/a2s_nobuild.sh
+++ b/share/tests/a2i.h/a2s/a2s_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2sh/a2sh_nobuild.sh b/share/tests/a2i.h/a2sh/a2sh_nobuild.sh
index 823f18b..d50ab1d 100755
--- a/share/tests/a2i.h/a2sh/a2sh_nobuild.sh
+++ b/share/tests/a2i.h/a2sh/a2sh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2shh/a2shh_nobuild.sh b/share/tests/a2i.h/a2shh/a2shh_nobuild.sh
index 72660f7..39527a6 100755
--- a/share/tests/a2i.h/a2shh/a2shh_nobuild.sh
+++ b/share/tests/a2i.h/a2shh/a2shh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2si/a2si_nobuild.sh b/share/tests/a2i.h/a2si/a2si_nobuild.sh
index 270032a..8a860f3 100755
--- a/share/tests/a2i.h/a2si/a2si_nobuild.sh
+++ b/share/tests/a2i.h/a2si/a2si_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2sl/a2sl_nobuild.sh b/share/tests/a2i.h/a2sl/a2sl_nobuild.sh
index 1deb89b..9bd1714 100755
--- a/share/tests/a2i.h/a2sl/a2sl_nobuild.sh
+++ b/share/tests/a2i.h/a2sl/a2sl_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2sll/a2sll_nobuild.sh b/share/tests/a2i.h/a2sll/a2sll_nobuild.sh
index 1459d9e..a2de6ef 100755
--- a/share/tests/a2i.h/a2sll/a2sll_nobuild.sh
+++ b/share/tests/a2i.h/a2sll/a2sll_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2u/a2u_nobuild.sh b/share/tests/a2i.h/a2u/a2u_nobuild.sh
index e073e42..c2ccecd 100755
--- a/share/tests/a2i.h/a2u/a2u_nobuild.sh
+++ b/share/tests/a2i.h/a2u/a2u_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2uh/a2uh_nobuild.sh b/share/tests/a2i.h/a2uh/a2uh_nobuild.sh
index 232f7e6..9903e9b 100755
--- a/share/tests/a2i.h/a2uh/a2uh_nobuild.sh
+++ b/share/tests/a2i.h/a2uh/a2uh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2uhh/a2uhh_nobuild.sh b/share/tests/a2i.h/a2uhh/a2uhh_nobuild.sh
index c2e5673..b297c70 100755
--- a/share/tests/a2i.h/a2uhh/a2uhh_nobuild.sh
+++ b/share/tests/a2i.h/a2uhh/a2uhh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2ui/a2ui_nobuild.sh b/share/tests/a2i.h/a2ui/a2ui_nobuild.sh
index 31ce0ee..a193830 100755
--- a/share/tests/a2i.h/a2ui/a2ui_nobuild.sh
+++ b/share/tests/a2i.h/a2ui/a2ui_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2ul/a2ul_nobuild.sh b/share/tests/a2i.h/a2ul/a2ul_nobuild.sh
index fe76808..72d724d 100755
--- a/share/tests/a2i.h/a2ul/a2ul_nobuild.sh
+++ b/share/tests/a2i.h/a2ul/a2ul_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/a2i.h/a2ull/a2ull_nobuild.sh b/share/tests/a2i.h/a2ull/a2ull_nobuild.sh
index adc2754..18b6d0e 100755
--- a/share/tests/a2i.h/a2ull/a2ull_nobuild.sh
+++ b/share/tests/a2i.h/a2ull/a2ull_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2i/str2i_nobuild.sh b/share/tests/str2i.h/str2i/str2i_nobuild.sh
index 5d4571a..28663f0 100755
--- a/share/tests/str2i.h/str2i/str2i_nobuild.sh
+++ b/share/tests/str2i.h/str2i/str2i_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2s/str2s_nobuild.sh b/share/tests/str2i.h/str2s/str2s_nobuild.sh
index 09a7851..c7b975f 100755
--- a/share/tests/str2i.h/str2s/str2s_nobuild.sh
+++ b/share/tests/str2i.h/str2s/str2s_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2sh/str2sh_nobuild.sh b/share/tests/str2i.h/str2sh/str2sh_nobuild.sh
index 7a30b92..66d8ecf 100755
--- a/share/tests/str2i.h/str2sh/str2sh_nobuild.sh
+++ b/share/tests/str2i.h/str2sh/str2sh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2shh/str2shh_nobuild.sh b/share/tests/str2i.h/str2shh/str2shh_nobuild.sh
index 3f59b0e..1cc2ee3 100755
--- a/share/tests/str2i.h/str2shh/str2shh_nobuild.sh
+++ b/share/tests/str2i.h/str2shh/str2shh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2si/str2si_nobuild.sh b/share/tests/str2i.h/str2si/str2si_nobuild.sh
index 33a8f2d..f478830 100755
--- a/share/tests/str2i.h/str2si/str2si_nobuild.sh
+++ b/share/tests/str2i.h/str2si/str2si_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2sl/str2sl_nobuild.sh b/share/tests/str2i.h/str2sl/str2sl_nobuild.sh
index afc141b..6dc6ab2 100755
--- a/share/tests/str2i.h/str2sl/str2sl_nobuild.sh
+++ b/share/tests/str2i.h/str2sl/str2sl_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2sll/str2sll_nobuild.sh b/share/tests/str2i.h/str2sll/str2sll_nobuild.sh
index 9714f2c..2e6b66e 100755
--- a/share/tests/str2i.h/str2sll/str2sll_nobuild.sh
+++ b/share/tests/str2i.h/str2sll/str2sll_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2u/str2u_nobuild.sh b/share/tests/str2i.h/str2u/str2u_nobuild.sh
index a0d35cd..bc642c4 100755
--- a/share/tests/str2i.h/str2u/str2u_nobuild.sh
+++ b/share/tests/str2i.h/str2u/str2u_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2uh/str2uh_nobuild.sh b/share/tests/str2i.h/str2uh/str2uh_nobuild.sh
index cc2f156..2ad74a2 100755
--- a/share/tests/str2i.h/str2uh/str2uh_nobuild.sh
+++ b/share/tests/str2i.h/str2uh/str2uh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2uhh/str2uhh_nobuild.sh b/share/tests/str2i.h/str2uhh/str2uhh_nobuild.sh
index cfb07ef..98e54ae 100755
--- a/share/tests/str2i.h/str2uhh/str2uhh_nobuild.sh
+++ b/share/tests/str2i.h/str2uhh/str2uhh_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2ui/str2ui_nobuild.sh b/share/tests/str2i.h/str2ui/str2ui_nobuild.sh
index b719232..ba78865 100755
--- a/share/tests/str2i.h/str2ui/str2ui_nobuild.sh
+++ b/share/tests/str2i.h/str2ui/str2ui_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2ul/str2ul_nobuild.sh b/share/tests/str2i.h/str2ul/str2ul_nobuild.sh
index 8a3cb1b..704d8a7 100755
--- a/share/tests/str2i.h/str2ul/str2ul_nobuild.sh
+++ b/share/tests/str2i.h/str2ul/str2ul_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";
 
diff --git a/share/tests/str2i.h/str2ull/str2ull_nobuild.sh b/share/tests/str2i.h/str2ull/str2ull_nobuild.sh
index 01af00d..1addcc4 100755
--- a/share/tests/str2i.h/str2ull/str2ull_nobuild.sh
+++ b/share/tests/str2i.h/str2ull/str2ull_nobuild.sh
@@ -7,7 +7,6 @@ set -Eeuf;
 
 
 out="$(mktemp)";
-CFLAGS="$CFLAGS -Werror";
 CFLAGS="$CFLAGS $(pkgconf --cflags liba2i)";
 LIBS="$(pkgconf --libs liba2i)";