diff options
| author | Mateusz Grzonka <mateusz.grzonka@intel.com> | 2023-03-23 12:50:00 +0100 |
|---|---|---|
| committer | Jes Sorensen <jes@trained-monkey.org> | 2023-03-23 12:44:09 -0400 |
| commit | ef6236da232e968dcf08b486178cd20d5ea97e2a (patch) | |
| tree | 7cf06409ee8cc9e14fac09dc960dc894b2da292d | |
| parent | 9b6e3b43381245cb128ad98bf117a565ce5defe5 (diff) | |
| download | mdadm-ef6236da232e968dcf08b486178cd20d5ea97e2a.tar.gz | |
Create: Fix checking for container in update_metadata
The commit 8a4ce2c05386 ("Create: Factor out add_disks() helpers")
introduced a regression that caused timeouts and udev failing to create
links.
Steps to reproduce the issue were as following:
$ mdadm -CR imsm -e imsm -n4 /dev/nvme[0-3]n1
$ mdadm -CR vol -l5 -n4 /dev/nvme[0-3]n1 --assume-clean
I found the check for container was wrong because negation was missing.
Fixes: 8a4ce2c05386 ("Create: Factor out add_disks() helpers")
Signed-off-by: Mateusz Grzonka <mateusz.grzonka@intel.com>
Signed-off-by: Jes Sorensen <jes@trained-monkey.org>
| -rw-r--r-- | Create.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -328,7 +328,7 @@ static int update_metadata(int mdfd, struct shape *s, struct supertype *st, * again returns container info. */ st->ss->getinfo_super(st, &info_new, NULL); - if (st->ss->external && is_container(s->level) && + if (st->ss->external && !is_container(s->level) && !same_uuid(info_new.uuid, info->uuid, 0)) { map_update(map, fd2devnm(mdfd), info_new.text_version, |