diff options
| author | Sebastian Huber <sebastian.huber@embedded-brains.de> | 2023-07-27 13:23:28 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2023-07-28 20:55:34 +1000 |
| commit | 6df5328a902cf719495ea8a07da383172e358fff (patch) | |
| tree | 18e4e8a968eaaec6136da375ddc5e8037889de02 | |
| parent | ccf1f62d59adc933fb348b866f351824cdd00c73 (diff) | |
| download | dtc-6df5328a902cf719495ea8a07da383172e358fff.tar.gz | |
Fix use of <ctype.h> functions
The value passed to the <ctype.h> functions shall be the value of an unsigned
char or EOF. It is implementation-defined if the char type is signed or
unsigned. Cast to unsigned char to avoid undefined behaviour on systems where
char is signed.
This cast is already present in other parts of the code base.
Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | checks.c | 2 | ||||
| -rw-r--r-- | yamltree.c | 2 |
2 files changed, 2 insertions, 2 deletions
@@ -1182,7 +1182,7 @@ static void check_unit_address_format(struct check *c, struct dt_info *dti, /* skip over 0x for next test */ unitname += 2; } - if (unitname[0] == '0' && isxdigit(unitname[1])) + if (unitname[0] == '0' && isxdigit((unsigned char)unitname[1])) FAIL(c, dti, node, "unit name should not have leading 0s"); } WARNING(unit_address_format, check_unit_address_format, NULL, @@ -102,7 +102,7 @@ static void yaml_propval_string(yaml_emitter_t *emitter, char *str, int len) /* Make sure the entire string is in the lower 7-bit ascii range */ for (i = 0; i < len; i++) - assert(isascii(str[i])); + assert(isascii((unsigned char)str[i])); yaml_scalar_event_initialize(&event, NULL, (const yaml_char_t *)YAML_STR_TAG, (const yaml_char_t*)str, |