mcelog: Rebalance the red-black tree after inserting a new nodev173

The original mcelog code rebalances the red-black tree after
finding an existed node, but doesn't rebalance the red-black
tree after inserting a new node for counting correctable
errors for a new page. This is incorrect.

Fix it by only rebalancing the red-black tree after inserting
a new node.

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>

1 files changed, 1 insertions, 2 deletions

diff --git a/page.c b/page.c
index 59b2204..1e73e17 100644
--- a/page.c
+++ b/page.c
@@ -100,6 +100,7 @@ mempage_insert_lookup(u64 addr, struct rb_node * node)
 			return mp;
 	}
 	rb_link_node(node, parent, p);
+	rb_insert_color(node, &mempage_root);
 	return NULL;
 }
 
@@ -107,8 +108,6 @@ static struct mempage *mempage_insert(u64 addr, struct mempage *mp)
 {
 	mp->addr = addr;
 	mp = mempage_insert_lookup(addr, &mp->nd);
-	if (mp != NULL)
-		rb_insert_color(&mp->nd, &mempage_root);
 	return mp;
 }