diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-07-16 13:14:52 +0200 |
|---|---|---|
| committer | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-07-19 12:53:25 +0200 |
| commit | a121d8d1d3ffd08da0fd72fe9980f0f2e6b9961a (patch) | |
| tree | b2af0df2b6c2e7f92771c25d0a11604a03194b8a | |
| parent | 719537b1f1decc000edd9706066fdda1d0a13f8d (diff) | |
| download | neard-a121d8d1d3ffd08da0fd72fe9980f0f2e6b9961a.tar.gz | |
unit: do not pass NULL to memcpy()
memcpy() should not receive NULL as source pointer and such is passed
from test_snep_read_get_req_frags_client_resp() and
test_snep_read_verify_resp(). ASAN reports:
unit/test-snep-read.c:325:2: runtime error: null pointer passed as argument 2, which is declared to never be null
unit/test-snep-read.c:266:2: runtime error: null pointer passed as argument 2, which is declared to never be null
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
| -rw-r--r-- | unit/test-snep-read.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/unit/test-snep-read.c b/unit/test-snep-read.c index 128937e..ea41ae0 100644 --- a/unit/test-snep-read.c +++ b/unit/test-snep-read.c @@ -261,7 +261,8 @@ static struct p2p_snep_req_frame *test_snep_build_req_frame( req->version = ver; req->request = req_type; req->length = GUINT_TO_BE(info_len); - memcpy(req->ndef, data, payload_len); + if (data) + memcpy(req->ndef, data, payload_len); return req; } @@ -320,7 +321,8 @@ static struct p2p_snep_resp_frame *test_snep_build_resp_frame( resp->version = ver; resp->response = resp_type; resp->length = GUINT_TO_BE(info_len); - memcpy(resp->info, data, info_len); + if (data) + memcpy(resp->info, data, info_len); return resp; } |