diff options
| author | Benjamin Poirier <bpoirier@nvidia.com> | 2023-12-11 09:07:14 -0500 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2023-12-22 09:54:23 -0800 |
| commit | ba1e68f04be3b6f391e236ff8e034709c8acc278 (patch) | |
| tree | d9468eb0f034c5c637c1dc08cd6239e7c3bd4369 | |
| parent | e8177094d51566f1eeed76fd2dae74601618dfdb (diff) | |
| download | iproute2-ba1e68f04be3b6f391e236ff8e034709c8acc278.tar.gz | |
bridge: vni: Remove dead code in group argument parsing
is_addrtype_inet_not_multi(&daddr) may read an uninitialized "daddr". Even
if that is fixed, the error message that follows cannot be reached because
the situation would be caught by the previous test (group_present).
Therefore, remove this test on daddr.
Fixes: 45cd32f9f7d5 ("bridge: vxlan device vnifilter support")
Reviewed-by: Petr Machata <petrm@nvidia.com>
Tested-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
| -rw-r--r-- | bridge/vni.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/bridge/vni.c b/bridge/vni.c index 6c0e35cda..33e50d18c 100644 --- a/bridge/vni.c +++ b/bridge/vni.c @@ -109,11 +109,6 @@ static int vni_modify(int cmd, int argc, char **argv) } else if (strcmp(*argv, "group") == 0) { if (group_present) invarg("duplicate group", *argv); - if (is_addrtype_inet_not_multi(&daddr)) { - fprintf(stderr, "vxlan: both group and remote"); - fprintf(stderr, " cannot be specified\n"); - return -1; - } NEXT_ARG(); get_addr(&daddr, *argv, AF_UNSPEC); if (!is_addrtype_inet_multi(&daddr)) |