diff options
author | Sam James <sam@gentoo.org> | 2023-11-24 23:08:04 +0000 |
---|---|---|
committer | Michal Kubecek <mkubecek@suse.cz> | 2024-01-28 17:07:17 +0100 |
commit | 7e3ccd489f522825117e1367f79465d267a04f58 (patch) | |
tree | fa8ff5b8272dec41ec71ff167660c3b0314f5592 | |
parent | 994ad92166c97e9cc29f0aa542c260180d2b7a3f (diff) | |
download | ethtool-7e3ccd489f522825117e1367f79465d267a04f58.tar.gz |
netlink: fix -Walloc-size
GCC 14 introduces a new -Walloc-size included in -Wextra which gives:
```
netlink/strset.c: In function ‘get_perdev_by_ifindex’:
netlink/strset.c:121:16: warning: allocation of insufficient size ‘1’ for type ‘struct perdev_strings’ with size ‘648’ [-Walloc-size]
121 | perdev = calloc(sizeof(*perdev), 1);
| ^
```
The calloc prototype is:
```
void *calloc(size_t nmemb, size_t size);
```
So, just swap the number of members and size arguments to match the prototype, as
we're initialising 1 struct of size `sizeof(*perdev)`. GCC then sees we're not
doing anything wrong. This is consistent with other use in the codebase too.
Signed-off-by: Sam James <sam@gentoo.org>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
-rw-r--r-- | netlink/strset.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/netlink/strset.c b/netlink/strset.c index fbc9c17..949d597 100644 --- a/netlink/strset.c +++ b/netlink/strset.c @@ -118,7 +118,7 @@ static struct perdev_strings *get_perdev_by_ifindex(int ifindex) return perdev; /* not found, allocate and insert into list */ - perdev = calloc(sizeof(*perdev), 1); + perdev = calloc(1, sizeof(*perdev)); if (!perdev) return NULL; perdev->ifindex = ifindex; |