diff options
author | Jakub Kicinski <kuba@kernel.org> | 2021-08-13 10:19:36 -0700 |
---|---|---|
committer | Michal Kubecek <mkubecek@suse.cz> | 2021-08-24 18:23:00 +0200 |
commit | 6cf8d25c5be464f770c80b0993bf6a96755c832d (patch) | |
tree | 1da367cb0830106f26d3028391559816d22e242c | |
parent | 8b8cb55d5625218e1142c7ac3a6b2e902ab1b63b (diff) | |
download | ethtool-6cf8d25c5be464f770c80b0993bf6a96755c832d.tar.gz |
ethtool: remove questionable goto
goto opt_found can be trivially replaced by an else branch.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r-- | ethtool.c | 13 |
1 files changed, 6 insertions, 7 deletions
@@ -6352,15 +6352,14 @@ int main(int argc, char **argp) nlfunc = args[k].nlfunc; nlchk = args[k].nlchk; no_dev = args[k].no_dev; - goto opt_found; + } else { + if ((*argp)[0] == '-') + exit_bad_args(); + nlfunc = nl_gset; + func = do_gset; + no_dev = false; } - if ((*argp)[0] == '-') - exit_bad_args(); - nlfunc = nl_gset; - func = do_gset; - no_dev = false; -opt_found: if (!no_dev) { ctx.devname = *argp++; argc--; |