Age | Commit message (Expand) | Author | Files | Lines |
10 days | dnsproxy: Fix cached ttl updateHEADmaster | Brian Fukano | 1 | -4/+2 |
10 days | iwd: set network to connected if it is already | Ram Subramanian | 1 | -0/+3 |
14 days | technology: Fix memory leak. | Robert Tiemann | 1 | -1/+3 |
14 days | wifi: Fix indentation. | Robert Tiemann | 1 | -5/+5 |
14 days | wifi: Fix memory leak. | Robert Tiemann | 1 | -1/+3 |
14 days | wifi: Fix use-after-free when tethering is disabled. | Robert Tiemann | 1 | -30/+24 |
2024-04-17 | dnsproxy: fix signedness warnings | Brian Fukano | 1 | -13/+24 |
2024-04-17 | inet: Ignore network devices used by NBD | Ćukasz Stelmach | 1 | -0/+6 |
2024-04-17 | ofono: delay device creation until lte settings are provisioned | Denis Kenzior | 1 | -0/+40 |
2024-04-17 | ofono: combine create_device and ready_to_create_device | Denis Kenzior | 1 | -47/+28 |
2024-04-17 | ofono: Set modem->interfaces earlier | Denis Kenzior | 1 | -9/+6 |
2024-04-17 | ofono: Add generic method to convert a list of strings to flags | Denis Kenzior | 1 | -9/+40 |
2024-04-17 | gdhcp: Allow client to work on veth devices | Denis Kenzior | 1 | -2/+7 |
2024-04-03 | gdhcp: Set pkt_len for packets received in L3 mode | John Mark | 1 | -0/+1 |
2024-02-15 | build: Remove really not needed tap-test utility | Marcel Holtmann | 3 | -200/+1 |
2024-01-26 | ofono: Don't invoke SetProperty unnecessarily | Denis Kenzior | 1 | -3/+2 |
2024-01-26 | ofono: Remove support for CDMA | Denis Kenzior | 1 | -417/+8 |
2023-12-28 | main: Use preprocessor definition rather than 'General' string literal. | Grant Erickson | 1 | -36/+39 |
2023-12-27 | service: Log service default, error, and state changes. | Grant Erickson | 1 | -6/+51 |
2023-12-27 | service: Make log output of 'online_check_is_enabled_check' consistent. | Grant Erickson | 1 | -2/+10 |
2023-12-27 | doc: Remove 'Experimental' designation from 'EnableOnlineToReadyTransition'. | Grant Erickson | 1 | -1/+0 |
2023-12-23 | timezone: Fix resolving of proper ISO3166 code from tz data | Jussi Laakkonen | 1 | -26/+152 |
2023-12-23 | device: Setup regdom when powering up to maintain consistency | Jussi Laakkonen | 1 | -0/+11 |
2023-12-23 | technology: Add global regdom and regdom getter | Jussi Laakkonen | 2 | -0/+28 |
2023-12-23 | doc: Correct 'OnlineCheck{Initial,Max}Interval' units. | Grant Erickson | 1 | -1/+1 |
2023-12-23 | main: Add deprecation warnings for 'EnableOnlineCheck' and 'EnableOnlineToRea... | Grant Erickson | 1 | -0/+8 |
2023-12-23 | main: Consolidate logging of online check-related settings. | Grant Erickson | 1 | -7/+40 |
2023-12-23 | main: Add comments tags for online check-related settings. | Grant Erickson | 1 | -1/+13 |
2023-12-23 | doc: Document the 'OnlineCheckMode' setting. | Grant Erickson | 3 | -67/+203 |
2023-12-23 | service: Leverage 'OnlineCheckMode' setting. | Grant Erickson | 2 | -20/+100 |
2023-12-23 | main/service: Introduce 'OnlineCheckMode' setting. | Grant Erickson | 3 | -0/+82 |
2023-12-23 | service: Add 'DBG' to 'downgrade_connected_services'. | Grant Erickson | 1 | -0/+2 |
2023-12-23 | service: Add @sa documentation reference to 'current_default'. | Grant Erickson | 1 | -0/+1 |
2023-12-23 | service: Add function parameter to 'default_changed' and 'service_list_sort'. | Grant Erickson | 1 | -16/+37 |
2023-12-23 | service: Document 'service_route_changed'. | Grant Erickson | 1 | -0/+19 |
2023-12-23 | service: Document 'service_schedule_changed'. | Grant Erickson | 1 | -0/+9 |
2023-12-23 | service: Document 'downgrade_connected_services'. | Grant Erickson | 1 | -0/+13 |
2023-12-23 | service: Document interval assignment in '__connman_service_wispr_start'. | Grant Erickson | 1 | -0/+5 |
2023-12-23 | service: Document the internals of 'service_compare'. | Grant Erickson | 1 | -0/+44 |
2023-12-23 | service: Add @sa documentation references. | Grant Erickson | 1 | -0/+7 |
2023-12-23 | service: Document 'handle_{continuous,oneshot}_online_check_failure'. | Grant Erickson | 1 | -0/+81 |
2023-12-23 | service: Document 'online_check_log_failure'. | Grant Erickson | 1 | -0/+16 |
2023-12-23 | service: Document 'handle_{continuous,oneshot}_online_check_success'. | Grant Erickson | 1 | -0/+61 |
2023-12-23 | service: Document 'continuous_online_check_log_{counter,failures,successes}_t... | Grant Erickson | 1 | -0/+51 |
2023-12-23 | service: Document 'online_check_log_success'. | Grant Erickson | 1 | -0/+14 |
2023-12-23 | service: Document 'online_check_counter_increment_and_log'. | Grant Erickson | 1 | -0/+18 |
2023-12-23 | service: Document 'online_check_successes_threshold_is_met'. | Grant Erickson | 1 | -0/+20 |
2023-12-23 | service: Document 'is_online_check_success_threshold_met_predicate'. | Grant Erickson | 1 | -0/+26 |
2023-12-23 | service: Document 'online_check_failures_threshold_is_met'. | Grant Erickson | 1 | -0/+20 |
2023-12-23 | service: Document 'is_online_check_failure_threshold_met_predicate'. | Grant Erickson | 1 | -0/+26 |
2023-12-23 | service: Document 'online_check_counter_threshold_is_met'. | Grant Erickson | 1 | -0/+32 |
2023-12-23 | service: Document 'online_check_counters_log'. | Grant Erickson | 1 | -0/+20 |
2023-12-23 | service: Document 'online_check_state_reset'. | Grant Erickson | 1 | -0/+16 |
2023-12-23 | service: Document 'online_check_{failures,successes}_reset'. | Grant Erickson | 1 | -0/+24 |
2023-12-23 | service: Document 'online_check_counter_reset'. | Grant Erickson | 1 | -0/+7 |
2023-12-23 | service: Document 'online_check_failures_threshold_was_met_{set,clear}'. | Grant Erickson | 1 | -0/+23 |
2023-12-23 | service: Document 'online_check_failures_threshold_was_met_set_value'. | Grant Erickson | 1 | -0/+14 |
2023-12-23 | service: Document 'online_check_failures_threshold_was_met'. | Grant Erickson | 1 | -0/+17 |
2023-12-23 | service: Complete 'continuous' online check mode implementation. | Grant Erickson | 1 | -18/+643 |
2023-12-23 | service: Capture IP configuration state by value rather than by pointer. | Grant Erickson | 1 | -5/+6 |
2023-12-23 | service: Move 'set_error' forward declaration earlier in the source. | Grant Erickson | 1 | -3/+2 |
2023-12-23 | service: Document 'connman_service' 'online_check_state_ipv{4,6}' members. | Grant Erickson | 1 | -0/+8 |
2023-12-23 | service: Document 'connman_service' 'online_check_failures_met_threshold' mem... | Grant Erickson | 1 | -0/+6 |
2023-12-23 | service: Add per-service online check failure threshold state. | Grant Erickson | 1 | -0/+1 |
2023-12-23 | doc: Document the 'OnlineCheck{Failures,Successes}Threshold' settings. | Grant Erickson | 2 | -0/+76 |
2023-12-23 | main: Introduce the 'OnlineCheck{Failures,Successes}Threshold' settings. | Grant Erickson | 1 | -0/+51 |
2023-12-23 | service: Document 'online_check_state' 'failures/successes' members. | Grant Erickson | 1 | -0/+10 |
2023-12-23 | service: Introduce and use online check 'failures/successes' state. | Grant Erickson | 1 | -0/+2 |
2023-12-23 | doc/service: Document online check failure service error. | Grant Erickson | 2 | -1/+9 |
2023-12-23 | service: Add online check failure service error enumeration and string. | Grant Erickson | 2 | -9/+12 |
2023-12-23 | session: Add service identifier to 'DBG' in four functions. | Grant Erickson | 1 | -6/+16 |
2023-12-23 | service: Add an explicit conditional for IPv6 in 'reschedule_online_check'. | Grant Erickson | 1 | -1/+3 |
2023-12-23 | service: Document 'start_online_check_if_connected_with_type'. | Grant Erickson | 1 | -0/+34 |
2023-12-23 | service: Refactor 'start_online_check_if_connected'. | Grant Erickson | 1 | -14/+49 |
2023-12-23 | service: Rename 'start_wispr_if_connected'. | Grant Erickson | 1 | -7/+7 |
2023-12-23 | service: Document 'online_check_active_{clear,set}'. | Grant Erickson | 1 | -0/+42 |
2023-12-23 | service: Document 'online_check_active_set_value'. | Grant Erickson | 1 | -0/+22 |
2023-12-23 | service: Document 'online_check_is_active'. | Grant Erickson | 1 | -0/+22 |
2023-12-23 | service: Document 'online_check_state' 'active' member. | Grant Erickson | 1 | -0/+3 |
2023-12-23 | service: Introduce and use online check 'active' state. | Grant Erickson | 1 | -0/+92 |
2023-12-23 | service: Change return type of 'start_wispr_if_connected'. | Grant Erickson | 1 | -2/+12 |
2023-12-23 | service: Change return type of 'start_online_check'. | Grant Erickson | 1 | -4/+24 |
2023-12-23 | service: Rename 'online_check_enabled_check'. | Grant Erickson | 1 | -3/+4 |
2023-12-23 | service: Sanity check the 'type' param in '__connman_service_wispr_start'. | Grant Erickson | 1 | -1/+9 |
2023-12-23 | service: Change return type of '__connman_service_wispr_start'. | Grant Erickson | 2 | -2/+10 |
2023-12-23 | ipconfig: Demote RTNL RTM_{ADD,DEL}ROUTE logs from info to DBG. | Grant Erickson | 1 | -2/+2 |
2023-12-23 | gateway: Expand the @param documentation for 'yield_default_gateway{,_for_typ... | Grant Erickson | 1 | -4/+8 |
2023-12-23 | gateway: Add and leveage 'gateway_config_set_{,in}active'. | Grant Erickson | 1 | -9/+18 |
2023-12-23 | gateway: Address unhandled gateway lifecycle events/transitions. | Grant Erickson | 1 | -12/+21 |
2023-12-23 | gateway: Handle -ESRCH in 'unset_default_gateway_route_common'. | Grant Erickson | 1 | -3/+25 |
2023-12-23 | inet: Use '__connman_inet_rtnl_recv' for RTNL default route transaction. | Grant Erickson | 1 | -0/+6 |
2023-12-23 | timeserver: Add service identifier to 'DBG' in 'ts_reset'. | Grant Erickson | 1 | -1/+2 |
2023-12-23 | session: Add service identifier to 'DBG' in 'service_state_changed'. | Grant Erickson | 1 | -1/+3 |
2023-12-23 | wispr: Make 'wispr_route_request' route add 'DBG' consistent. | Grant Erickson | 1 | -12/+18 |
2023-12-23 | service: Qualify call to '__connman_timeserver_sync' with default check. | Grant Erickson | 1 | -2/+19 |
2023-12-16 | inet: Document '__connman_service_nameserver_{add,del}_routes'. | Grant Erickson | 1 | -0/+44 |
2023-12-16 | inet: Document 'nameserver_{add,del}_routes'. | Grant Erickson | 1 | -0/+50 |
2023-12-16 | inet: Document '{add,del}_nameserver_route'. | Grant Erickson | 1 | -0/+53 |
2023-12-16 | service: Add 'DBG' to 'add_nameserver_route'. | Grant Erickson | 1 | -0/+3 |
2023-12-16 | service: Const-qualify 'add_nameserver_route'. | Grant Erickson | 1 | -1/+1 |
2023-12-16 | inet: Document 'connman_inet_{add,del}_{,ipv6_}host_route'. | Grant Erickson | 1 | -0/+144 |
2023-12-16 | inet: Add gateway parameter to 'connman_inet_del_{,ipv6_}host_route'. | Grant Erickson | 4 | -22/+77 |
2023-12-16 | service: Add gateway parameter to DNS host route deletion paths. | Grant Erickson | 3 | -12/+30 |
2023-12-16 | service: Refactor 'nameserver_del_routes'. | Grant Erickson | 1 | -15/+26 |
2023-12-16 | wispr: Leverage '__connman_service_get_route_metric'. | Grant Erickson | 1 | -0/+11 |
2023-12-16 | wispr: Document 'wispr_portal_context_route_ops'. | Grant Erickson | 1 | -0/+10 |
2023-12-16 | wispr: Document 'wispr_route'. | Grant Erickson | 1 | -0/+19 |
2023-12-16 | wispr: Document 'free_wispr_route{,s}'. | Grant Erickson | 1 | -0/+34 |
2023-12-16 | wispr: Simplify IPv4 vs. IPv6 host route management. | Grant Erickson | 1 | -30/+82 |
2023-12-16 | wispr: Refactor 'free_wispr_routes'. | Grant Erickson | 1 | -19/+26 |
2023-12-16 | wispr: Update 'DBG' in '__connman_wispr_start'. | Grant Erickson | 1 | -1/+1 |
2023-12-16 | wispr: Add 'DBG' to '__connman_wispr_start' error path. | Grant Erickson | 1 | -0/+2 |
2023-12-16 | wispr: Expand 'DBG' in 'wispr_portal_detect'. | Grant Erickson | 1 | -2/+2 |
2023-12-16 | service: Document '__connman_service_get_route_metric'. | Grant Erickson | 1 | -0/+34 |
2023-12-16 | service: Add '__connman_service_get_route_metric'. | Grant Erickson | 2 | -0/+66 |
2023-12-15 | service: Both cancel and stop online checks where appropriate. | Grant Erickson | 1 | -0/+5 |
2023-12-15 | service: Add support for 'CONNMAN_IPCONFIG_TYPE_ALL' to 'cancel_online_check'. | Grant Erickson | 1 | -10/+28 |
2023-12-15 | inet: Eliminate dead store in 'iproute_default_modify'. | Grant Erickson | 1 | -1/+0 |
2023-12-15 | inet: Document IPv{4,6} host/network route functions with metric/priority. | Grant Erickson | 1 | -0/+338 |
2023-12-15 | connection: Document 'inet_modify_{,ipv4_,ipv6_}{host,network}_route'. | Grant Erickson | 1 | -0/+321 |
2023-12-15 | connection: Document 'inet_modify_host_or_network_route'. | Grant Erickson | 1 | -0/+61 |
2023-12-15 | connection: Document 'inet_mask_addr_data'. | Grant Erickson | 1 | -0/+25 |
2023-12-15 | connection: Document 'inet_get_addr_data'. | Grant Erickson | 1 | -0/+31 |
2023-12-15 | inet: Add IPv{4,6} host/network route functions with metric/priority. | Grant Erickson | 2 | -32/+479 |
2023-12-15 | inet: Reorder IPv6 host and network route function declarations. | Grant Erickson | 1 | -3/+4 |
2023-12-15 | inet: Relocate 'rtnl_route_cmd2string'. | Grant Erickson | 1 | -12/+12 |
2023-12-15 | connection: Document '__connman_inet_rtnl_recv'. | Grant Erickson | 1 | -0/+34 |
2023-12-15 | inet: Add '__connman_inet_rtnl_recv'. | Grant Erickson | 2 | -15/+41 |
2023-12-14 | gateway: Rename public and private symbols after file rename. | Grant Erickson | 8 | -58/+58 |
2023-12-14 | gateway: Updated @file comment to reflect recent rename. | Grant Erickson | 1 | -3/+2 |
2023-12-14 | connection: Rename 'connection.c' to 'gateway.c'. | Grant Erickson | 3 | -2/+2 |
2023-12-08 | connection: Fix typo in @file comment. | Grant Erickson | 1 | -1/+1 |
2023-12-08 | connection: Ensure function attribution 'DBG' output is consistent. | Grant Erickson | 1 | -3/+3 |
2023-12-08 | connection: Add whitespace around 'del_gateway_routes_if_active'. | Grant Erickson | 1 | -0/+2 |
2023-12-08 | connection: Add @file comment. | Grant Erickson | 1 | -0/+208 |
2023-12-08 | connection: Update '{un,}set_default_gateway' documentation. | Grant Erickson | 1 | -28/+64 |
2023-12-08 | connection: Update 'unset_default_gateway_route_common' documentation. | Grant Erickson | 1 | -0/+3 |
2023-12-08 | connection: Update 'set_default_gateway_route_common' documentation. | Grant Erickson | 1 | -0/+3 |
2023-12-08 | connection: Fix documentation typos. | Grant Erickson | 1 | -2/+2 |
2023-12-08 | connection: Document 'unset_low_priority_default_gateway'. | Grant Erickson | 1 | -0/+44 |
2023-12-08 | connection: Document 'unset_ipv4_low_priority_default_gateway'. | Grant Erickson | 1 | -0/+44 |
2023-12-08 | connection: Document 'unset_ipv4_low_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+35 |
2023-12-08 | connection: Document 'set_low_priority_default_gateway'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | connection: Document 'set_ipv4_low_priority_default_gateway'. | Grant Erickson | 1 | -0/+43 |
2023-12-08 | connection: Document 'set_ipv4_low_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+36 |
2023-12-08 | connection: Document 'unset_ipv6_high_priority_default_gateway'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | connection: Document 'unset_ipv4_high_priority_default_gateway'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | connection: Document 'unset_ipv6_high_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+36 |
2023-12-08 | connection: Document 'unset_ipv4_high_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+36 |
2023-12-08 | connection: Document 'set_ipv6_high_priority_default_gateway'. | Grant Erickson | 1 | -0/+43 |
2023-12-08 | connection: Document 'set_ipv4_high_priority_default_gateway'. | Grant Erickson | 1 | -0/+43 |
2023-12-08 | connection: Document 'set_ipv6_high_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+36 |
2023-12-08 | connection: Document 'set_ipv4_high_priority_default_gateway_route_cb'. | Grant Erickson | 1 | -0/+36 |
2023-12-08 | connection: Document 'promote_default_gateway'. | Grant Erickson | 1 | -0/+50 |
2023-12-08 | connection: Document 'demote_default_gateway'. | Grant Erickson | 1 | -0/+49 |
2023-12-08 | connection: Document call to 'connman_service_unref'. | Grant Erickson | 1 | -0/+4 |
2023-12-08 | connection: Document 'add_host_route'. | Grant Erickson | 1 | -0/+23 |
2023-12-08 | connection: Document 'compute_low_priority_metric'. | Grant Erickson | 1 | -0/+45 |
2023-12-08 | connection: Update 'find_any_active_gateway_data' documentation. | Grant Erickson | 1 | -4/+4 |
2023-12-08 | connection: Document 'is_addr_any_str'. | Grant Erickson | 1 | -0/+21 |
2023-12-08 | connection: Document 'gateway_hash'. | Grant Erickson | 1 | -0/+5 |
2023-12-08 | connection: Document 'gateway_data'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | connection: Document 'gateway_config'. | Grant Erickson | 1 | -0/+11 |
2023-12-08 | connection: Document 'gateway_config_ops'. | Grant Erickson | 1 | -0/+9 |
2023-12-08 | connection: Document 'gateway_config_state' finite state machine. | Grant Erickson | 1 | -1/+24 |
2023-12-08 | connection: Add 'DBG' else clauses to 'connection_delgateway'. | Grant Erickson | 1 | -2/+4 |
2023-12-08 | connection: Refactor 'add_host_route'. | Grant Erickson | 1 | -42/+32 |
2023-12-08 | connection: Introduce gateway config 'ops' | Grant Erickson | 1 | -30/+134 |
2023-12-08 | connection: Add 'is_addr_any_str'. | Grant Erickson | 1 | -8/+17 |
2023-12-08 | connection: Introduce '{de,pro}mote_default_gateway'. | Grant Erickson | 1 | -81/+100 |
2023-12-08 | connection: Add support for low-priority default routes. | Grant Erickson | 1 | -63/+308 |
2023-12-08 | inet: Document '__connman_inet_{add,del}_default_{to,from}_table_with_metric'. | Grant Erickson | 1 | -0/+66 |
2023-12-08 | inet: Add '__connman_inet_{add,del}_default_{to,from}_table_with_metric'. | Grant Erickson | 2 | -0/+38 |
2023-12-08 | connection: Document '__connman_inet_del_default_to_table'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | connection: Document '__connman_inet_add_default_to_table'. | Grant Erickson | 1 | -0/+32 |
2023-12-08 | inet: Document 'iproute_default_modify'. | Grant Erickson | 1 | -0/+39 |
2023-12-08 | inet: Add a metric parameter to 'iproute_default_modify'. | Grant Erickson | 1 | -12/+35 |
2023-12-08 | ipconfig: Use 'RT_SCOPE_*' mnemonics. | Grant Erickson | 1 | -2/+2 |
2023-12-08 | inet: Include the command value and string in 'DBG' | Grant Erickson | 1 | -1/+14 |
2023-12-08 | inet: Include interface index and name in 'DBG'. | Grant Erickson | 1 | -1/+5 |
2023-12-08 | ipconfig: Pass the rtnl dst prefixlen to '__connman_ipconfig_{new,del}route'. | Grant Erickson | 3 | -20/+32 |
2023-12-08 | ipconfig: Pass the rtnl metric to '__connman_ipconfig_{new,del}route'. | Grant Erickson | 3 | -16/+24 |
2023-12-08 | rtnl: Add support for extracting the metric/priority. | Grant Erickson | 1 | -6/+16 |
2023-12-08 | ipconfig: Pass the rtnl table to '__connman_ipconfig_{new,del}route'. | Grant Erickson | 3 | -16/+28 |
2023-12-08 | rtnl: Add support for extracting the table identifier. | Grant Erickson | 1 | -6/+20 |
2023-12-08 | inet: Leverage '__connman_inet_table2string'. | Grant Erickson | 1 | -1/+3 |
2023-12-08 | inet: Document '__connman_inet_table2string'. | Grant Erickson | 1 | -0/+17 |
2023-12-08 | inet: Add '__connman_inet_table2string'. | Grant Erickson | 2 | -0/+20 |
2023-12-08 | connection: Document 'unset_default_gateway_route_common'. | Grant Erickson | 1 | -0/+43 |
2023-12-08 | connection: Document 'set_default_gateway_route_common'. | Grant Erickson | 1 | -0/+45 |
2023-12-08 | connection: Document 'mutate_default_gateway_route_cb_t'. | Grant Erickson | 1 | -0/+17 |
2023-12-08 | connection: Fan out route manipulation into callbacks. | Grant Erickson | 1 | -10/+91 |
2023-12-08 | connection: Change return type of 'set_default_gateway'. | Grant Erickson | 1 | -2/+8 |
2023-12-08 | connection: Leverage 'unset_default_gateway' in 'del_gateway_routes'. | Grant Erickson | 1 | -12/+10 |
2023-12-08 | connection: Change return type of 'unset_default_gateway'. | Grant Erickson | 1 | -2/+5 |
2023-12-08 | connection: Add low-priority default gateway config type. | Grant Erickson | 1 | -1/+9 |
2023-12-08 | connection: Add gateway config ADDED/REMOVED states. | Grant Erickson | 1 | -1/+17 |
2023-12-08 | connection: Document 'mutate_default_gateway'. | Grant Erickson | 1 | -0/+25 |
2023-12-08 | connection: Document 'mutate_default_gateway_ops'. | Grant Erickson | 1 | -0/+34 |
2023-12-08 | connection: Introduce and leverage 'mutate_default_gateway'. | Grant Erickson | 1 | -59/+83 |