diff options
| author | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-02-05 14:41:30 +0200 |
|---|---|---|
| committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-02-05 17:12:12 +0200 |
| commit | 5c8390ff842cf7741493f3282e935bc36ff9ad7e (patch) | |
| tree | 52c27b221e9f7e200e069743596b43d371fdaa4d | |
| parent | cd0605d7430ad5e51a4efe94947753b6f5edcc00 (diff) | |
| download | aiaiai-5c8390ff842cf7741493f3282e935bc36ff9ad7e.tar.gz | |
email-test-patchset: remove a useless variable
This is another cosmetic clean-up. Just trying to make this script a bit
smaller and more readable. Remove the 'msgname' variable since we only use it
once.
Also, substitute 'echo' with 'printf', since we are trying to not using echo as
a general policy, see this URL for more infor why echo may be dangeros and
printf is safe:
http://unix.stackexchange.com/questions/65803/why-is-printf-better-than-echo
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
| -rwxr-xr-x | email/aiaiai-email-test-patchset | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/email/aiaiai-email-test-patchset b/email/aiaiai-email-test-patchset index 3abc960..040e5d7 100755 --- a/email/aiaiai-email-test-patchset +++ b/email/aiaiai-email-test-patchset @@ -278,10 +278,9 @@ fi fetch_header_or_die subj "Subject" < "$mbox" fetch_header_or_die from "From" < "$mbox" fetch_header_or_die id "Message-Id" < "$mbox" -msgname="$from: $subj (Message-Id: $id)" -echo >&2 -verbose "Testing mbox: \"$msgname\"" +printf "\n" +verbose "Testing mbox: \"$from: $subj (Message-Id: $id)\"" verbose "parsing config file \"$cfgfile\"" parse_config "$cfgfile" |