aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2009-06-18 16:52:49 +0000
committerChristopher Li <sparse@chrisli.org>2009-07-18 05:30:10 +0000
commit59df2fd69755fe8fb36420ea163f9aa52346e61a (patch)
treeb86c28f08f961b812830eca363587e7f8551565c
parent7ffff9cb3d04c99107dee6f4283311a9b132d67b (diff)
downloadsparse-59df2fd69755fe8fb36420ea163f9aa52346e61a.tar.gz
Turn off '-Wtransparent-union' by default
It's a very annoying warning, and it's about a sparse limitation rather than a real feature, so don't do it by default. Sure, our lack of transparent union support will then make us warn about the magic calling convention hacks (eg you'll see warnings like connect.c:240:39: warning: incorrect type in argument 2 (invalid types) connect.c:240:39: expected union __CONST_SOCKADDR_ARG [usertype] __addr connect.c:240:39: got struct sockaddr *ai_addr but it still doesn't mean that we have to be so noisy about just seeing those transparent unions. One annoying warning is not an argument for doing _another_ annoying warning too (and the calling convention warnings at least only happen if you actually use them, unlike the transparent union warning that happens every time we see one, used or not). Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Christopher Li <sparse@chrisli.org>
-rw-r--r--lib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib.c b/lib.c
index 2b8d21ed..42affcdb 100644
--- a/lib.c
+++ b/lib.c
@@ -206,7 +206,7 @@ int Wparen_string = 0;
int Wptr_subtraction_blows = 0;
int Wreturn_void = 0;
int Wshadow = 0;
-int Wtransparent_union = 1;
+int Wtransparent_union = 0;
int Wtypesign = 0;
int Wundef = 0;
int Wuninitialized = 1;