diff options
| author | Mark Zhang <markzhang@nvidia.com> | 2023-09-27 12:05:11 +0300 |
|---|---|---|
| committer | Leon Romanovsky <leon@kernel.org> | 2023-10-02 13:10:40 +0300 |
| commit | e0fe97efdb00f0f32b038a4836406a82886aec9c (patch) | |
| tree | 0ec9f51072e4222c14d5c58f266e58ded7b58094 | |
| parent | 374012b0045780b7ad498be62e85153009bb7fe9 (diff) | |
| download | vfs-e0fe97efdb00f0f32b038a4836406a82886aec9c.tar.gz | |
RDMA/cma: Initialize ib_sa_multicast structure to 0 when join
Initialize the structure to 0 so that it's fields won't have random
values. For example fields like rec.traffic_class (as well as
rec.flow_label and rec.sl) is used to generate the user AH through:
cma_iboe_join_multicast
cma_make_mc_event
ib_init_ah_from_mcmember
And a random traffic_class causes a random IP DSCP in RoCEv2.
Fixes: b5de0c60cc30 ("RDMA/cma: Fix use after free race in roce multicast join")
Signed-off-by: Mark Zhang <markzhang@nvidia.com>
Link: https://lore.kernel.org/r/20230927090511.603595-1-markzhang@nvidia.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
| -rw-r--r-- | drivers/infiniband/core/cma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index c343edf2f66401..1e2cd7c8716e81 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -4968,7 +4968,7 @@ static int cma_iboe_join_multicast(struct rdma_id_private *id_priv, int err = 0; struct sockaddr *addr = (struct sockaddr *)&mc->addr; struct net_device *ndev = NULL; - struct ib_sa_multicast ib; + struct ib_sa_multicast ib = {}; enum ib_gid_type gid_type; bool send_only; |