diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2023-09-30 11:01:38 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2023-09-30 11:01:38 -0700 |
| commit | 25d48d570eeda62cf71e5b9cdad76a37b833f408 (patch) | |
| tree | 29c3038ae0489cc30b7332e8ff8d4ce919a5d4ab | |
| parent | cefc06e4de1477dbdc3cb2a91d4b1873b7797a5c (diff) | |
| parent | 684f7e6d28e8087502fc8efdb6c9fe82400479dd (diff) | |
| download | vfs-25d48d570eeda62cf71e5b9cdad76a37b833f408.tar.gz | |
Merge tag 'iomap-6.6-fixes-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
Pull iomap fixes from Darrick Wong:
- Handle a race between writing and shrinking block devices by
returning EIO
- Fix a typo in a comment
* tag 'iomap-6.6-fixes-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
iomap: Spelling s/preceeding/preceding/g
iomap: add a workaround for racy i_size updates on block devices
| -rw-r--r-- | fs/buffer.c | 11 | ||||
| -rw-r--r-- | fs/iomap/buffered-io.c | 2 |
2 files changed, 11 insertions, 2 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index a6785cd07081c..12e9a71c693d7 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2058,8 +2058,17 @@ iomap_to_bh(struct inode *inode, sector_t block, struct buffer_head *bh, fallthrough; case IOMAP_MAPPED: if ((iomap->flags & IOMAP_F_NEW) || - offset >= i_size_read(inode)) + offset >= i_size_read(inode)) { + /* + * This can happen if truncating the block device races + * with the check in the caller as i_size updates on + * block devices aren't synchronized by i_rwsem for + * block devices. + */ + if (S_ISBLK(inode->i_mode)) + return -EIO; set_buffer_new(bh); + } bh->b_blocknr = (iomap->addr + offset - iomap->offset) >> inode->i_blkbits; set_buffer_mapped(bh); diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 644479ccefbd0..5db54ca29a35a 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -1049,7 +1049,7 @@ static int iomap_write_delalloc_punch(struct inode *inode, struct folio *folio, /* * Scan the data range passed to us for dirty page cache folios. If we find a - * dirty folio, punch out the preceeding range and update the offset from which + * dirty folio, punch out the preceding range and update the offset from which * the next punch will start from. * * We can punch out storage reservations under clean pages because they either |