diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-03-28 23:50:20 +0000 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-03-30 13:40:00 +0200 |
| commit | 821eba962d95806beb0440742c4062a9da8a386b (patch) | |
| tree | 430cb6cb9affac79615cb4c49193c94758921e26 /net/core/dev.c | |
| parent | c59647c0dc679008886756a888368da1c6d4ccd3 (diff) | |
| download | linux-821eba962d95806beb0440742c4062a9da8a386b.tar.gz | |
net: optimize napi_schedule_rps()
Based on initial patch from Jason Xing.
Idea is to not raise NET_RX_SOFTIRQ from napi_schedule_rps()
when we queued a packet into another cpu backlog.
We can do this only in the context of us being called indirectly
from net_rx_action(), to have the guarantee our rps_ipi_list
will be processed before we exit from net_rx_action().
Link: https://lore.kernel.org/lkml/20230325152417.5403-1-kerneljasonxing@gmail.com/
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jason Xing <kernelxing@tencent.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Tested-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 15331edbacf4c..f34ce93f2f02e 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4587,8 +4587,6 @@ static void trigger_rx_softirq(void *data) * * - If this is another cpu queue, link it to our rps_ipi_list, * and make sure we will process rps_ipi_list from net_rx_action(). - * As we do not know yet if we are called from net_rx_action(), - * we have to raise NET_RX_SOFTIRQ. This might change in the future. * * - If this is our own queue, NAPI schedule our backlog. * Note that this also raises NET_RX_SOFTIRQ. @@ -4602,7 +4600,11 @@ static void napi_schedule_rps(struct softnet_data *sd) sd->rps_ipi_next = mysd->rps_ipi_list; mysd->rps_ipi_list = sd; - __raise_softirq_irqoff(NET_RX_SOFTIRQ); + /* If not called from net_rx_action() + * we have to raise NET_RX_SOFTIRQ. + */ + if (!mysd->in_net_rx_action) + __raise_softirq_irqoff(NET_RX_SOFTIRQ); return; } #endif /* CONFIG_RPS */ |