diff options
| author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2023-02-14 13:01:17 -0800 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-02-16 10:11:14 +0100 |
| commit | 3ba0bf47edf955d6f52fdb16b54acd1932cb9445 (patch) | |
| tree | e593d1ef314f8a6aba545f46622f8835af5c51cc /net/core/dev.c | |
| parent | 802dcbd6f30feaa7c96a1fb4ecb1db57082df9d7 (diff) | |
| download | linux-3ba0bf47edf955d6f52fdb16b54acd1932cb9445.tar.gz | |
net/core: refactor promiscuous mode message
The kernel stack can be more consistent by printing the IFF_PROMISC
aka promiscuous enable/disable messages with the standard netdev_info
message which can include bus and driver info as well as the device.
typical command usage from user space looks like:
ip link set eth0 promisc <on|off>
But lots of utilities such as bridge, tcpdump, etc put the interface into
promiscuous mode.
old message:
[ 406.034418] device eth0 entered promiscuous mode
[ 408.424703] device eth0 left promiscuous mode
new message:
[ 406.034431] ice 0000:17:00.0 eth0: entered promiscuous mode
[ 408.424715] ice 0000:17:00.0 eth0: left promiscuous mode
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index ad1e6482e1c15c..357081b0113cb5 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -8321,9 +8321,8 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify) } } if (dev->flags != old_flags) { - pr_info("device %s %s promiscuous mode\n", - dev->name, - dev->flags & IFF_PROMISC ? "entered" : "left"); + netdev_info(dev, "%s promiscuous mode\n", + dev->flags & IFF_PROMISC ? "entered" : "left"); if (audit_enabled) { current_uid_gid(&uid, &gid); audit_log(audit_context(), GFP_ATOMIC, |