diff options
| author | Kees Cook <keescook@chromium.org> | 2024-03-09 12:24:48 -0800 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2024-04-03 14:45:03 -0700 |
| commit | 9c573cd313433f6c1f7236fe64b9b743500c1628 (patch) | |
| tree | 69e9397102c2704709368fb199287944bb295a4d /include | |
| parent | bbda3ba626b9f57ff6063058877eca856f5b734d (diff) | |
| download | linux-9c573cd313433f6c1f7236fe64b9b743500c1628.tar.gz | |
randomize_kstack: Improve entropy diffusion
The kstack_offset variable was really only ever using the low bits for
kernel stack offset entropy. Add a ror32() to increase bit diffusion.
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 39218ff4c625 ("stack: Optionally randomize kernel stack offset each syscall")
Link: https://lore.kernel.org/r/20240309202445.work.165-kees@kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/randomize_kstack.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/randomize_kstack.h b/include/linux/randomize_kstack.h index 5d868505a94e4..6d92b68efbf6c 100644 --- a/include/linux/randomize_kstack.h +++ b/include/linux/randomize_kstack.h @@ -80,7 +80,7 @@ DECLARE_PER_CPU(u32, kstack_offset); if (static_branch_maybe(CONFIG_RANDOMIZE_KSTACK_OFFSET_DEFAULT, \ &randomize_kstack_offset)) { \ u32 offset = raw_cpu_read(kstack_offset); \ - offset ^= (rand); \ + offset = ror32(offset, 5) ^ (rand); \ raw_cpu_write(kstack_offset, offset); \ } \ } while (0) |