diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-03-26 13:47:22 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-03-27 13:17:15 +0100 |
| commit | 22650a99821dda3d05f1c334ea90330b4982de56 (patch) | |
| tree | d6dbade087df53eb660d654d876a35c6d1a59a54 /include | |
| parent | 3ff56e285de5a375fbfab3c3f1af81bbd23db36d (diff) | |
| download | linux-22650a99821dda3d05f1c334ea90330b4982de56.tar.gz | |
fs,block: yield devices early
Currently a device is only really released once the umount returns to
userspace due to how file closing works. That ultimately could cause
an old umount assumption to be violated that concurrent umount and mount
don't fail. So an exclusively held device with a temporary holder should
be yielded before the filesystem is gone. Add a helper that allows
callers to do that. This also allows us to remove the two holder ops
that Linus wasn't excited about.
Link: https://lore.kernel.org/r/20240326-vfs-bdev-end_holder-v1-1-20af85202918@kernel.org
Fixes: f3a608827d1f ("bdev: open block device as files") # mainline only
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/blkdev.h | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index c3e8f7cf96be9..172c918799995 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1505,16 +1505,6 @@ struct blk_holder_ops { * Thaw the file system mounted on the block device. */ int (*thaw)(struct block_device *bdev); - - /* - * If needed, get a reference to the holder. - */ - void (*get_holder)(void *holder); - - /* - * Release the holder. - */ - void (*put_holder)(void *holder); }; /* @@ -1585,6 +1575,7 @@ static inline int early_lookup_bdev(const char *pathname, dev_t *dev) int bdev_freeze(struct block_device *bdev); int bdev_thaw(struct block_device *bdev); +void bdev_fput(struct file *bdev_file); struct io_comp_batch { struct request *req_list; |