diff options
| author | Bob Peterson <rpeterso@redhat.com> | 2015-03-27 08:25:41 -0500 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2016-03-15 10:46:45 -0400 |
| commit | ff34245d524a898eee6e013eb1ec165095277148 (patch) | |
| tree | 4c3c0abc8bd6cdaca2b0ab5667f0c72f0dbada0e /fs/gfs2/glock.c | |
| parent | a4923865ea071b0bd708339df7a83c76732fa2db (diff) | |
| download | linux-ff34245d524a898eee6e013eb1ec165095277148.tar.gz | |
GFS2: Don't filter out I_FREEING inodes anymore
This patch basically reverts a very old patch from 2008,
7a9f53b3c1875bef22ad4588e818bc046ef183da, with the title
"Alternate gfs2_iget to avoid looking up inodes being freed".
The original patch was designed to avoid a deadlock caused by lock
ordering with try_rgrp_unlink. The patch forced the function to not
find inodes that were being removed by VFS. The problem is, that
made it impossible for nodes to delete their own unlinked dinodes
after a certain point in time, because the inode needed was not found
by this filtering process. There is no longer a need for the patch,
since function try_rgrp_unlink no longer locks the inode: All it does
is queue the glock onto the delete work_queue, so there should be no
more deadlock.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/glock.c')
| -rw-r--r-- | fs/gfs2/glock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index 7f0257309b3e8a..6539131c52a24f 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -582,7 +582,7 @@ static void delete_work_func(struct work_struct *work) /* Note: Unsafe to dereference ip as we don't hold right refs/locks */ if (ip) - inode = gfs2_ilookup(sdp->sd_vfs, no_addr, 1); + inode = gfs2_ilookup(sdp->sd_vfs, no_addr); else inode = gfs2_lookup_by_inum(sdp, no_addr, NULL, GFS2_BLKST_UNLINKED); if (inode && !IS_ERR(inode)) { |