diff options
| author | Chen Jiahao <chenjiahao16@huawei.com> | 2023-08-02 17:36:50 +0800 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2023-08-10 09:35:28 +0200 |
| commit | df9c16b5ccc8e4aab5e492b5f110167c75c74b0a (patch) | |
| tree | 8cce73830d14ccf02b4d75aee34867a6c16d342a /drivers/rtc/rtc-sunplus.c | |
| parent | a69c610e13e2b2de8a1ed2683f13e21b3200bd7a (diff) | |
| download | linux-df9c16b5ccc8e4aab5e492b5f110167c75c74b0a.tar.gz | |
rtc: sunplus: Clean up redundant dev_err_probe()
Referring to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.
Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.
Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Link: https://lore.kernel.org/r/20230802093650.976352-1-chenjiahao16@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc/rtc-sunplus.c')
| -rw-r--r-- | drivers/rtc/rtc-sunplus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-sunplus.c b/drivers/rtc/rtc-sunplus.c index f33dc301f3019..20c7e97c2fc81 100644 --- a/drivers/rtc/rtc-sunplus.c +++ b/drivers/rtc/rtc-sunplus.c @@ -244,7 +244,7 @@ static int sp_rtc_probe(struct platform_device *plat_dev) sp_rtc->irq = platform_get_irq(plat_dev, 0); if (sp_rtc->irq < 0) - return dev_err_probe(&plat_dev->dev, sp_rtc->irq, "platform_get_irq failed\n"); + return sp_rtc->irq; ret = devm_request_irq(&plat_dev->dev, sp_rtc->irq, sp_rtc_irq_handler, IRQF_TRIGGER_RISING, "rtc irq", plat_dev); |