aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/rtc/rtc-sunplus.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-01-06 15:57:11 +0800
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2022-01-16 23:50:34 +0100
commit5ceee540fdc7f1d65ca6e2b1b193ce5aa95ab99c (patch)
tree7c25b3d731341cbc0c00aebcb75710fc46349f55 /drivers/rtc/rtc-sunplus.c
parentff164ae39b82ee483b24579c8e22a13a8ce5bd04 (diff)
downloadlinux-5ceee540fdc7f1d65ca6e2b1b193ce5aa95ab99c.tar.gz
rtc: sunplus: fix return value in sp_rtc_probe()
If devm_ioremap_resource() fails, it should return error code from sp_rtc->reg_base in sp_rtc_probe(). Fixes: fad6cbe9b2b4 ("rtc: Add driver for RTC in Sunplus SP7021") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20220106075711.3216468-1-yangyingliang@huawei.com
Diffstat (limited to 'drivers/rtc/rtc-sunplus.c')
-rw-r--r--drivers/rtc/rtc-sunplus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-sunplus.c b/drivers/rtc/rtc-sunplus.c
index 0b3873204f5cd..e8e2ab1103fc0 100644
--- a/drivers/rtc/rtc-sunplus.c
+++ b/drivers/rtc/rtc-sunplus.c
@@ -238,7 +238,7 @@ static int sp_rtc_probe(struct platform_device *plat_dev)
sp_rtc->res = platform_get_resource_byname(plat_dev, IORESOURCE_MEM, RTC_REG_NAME);
sp_rtc->reg_base = devm_ioremap_resource(&plat_dev->dev, sp_rtc->res);
if (IS_ERR(sp_rtc->reg_base))
- return dev_err_probe(&plat_dev->dev, PTR_ERR(sp_rtc->res),
+ return dev_err_probe(&plat_dev->dev, PTR_ERR(sp_rtc->reg_base),
"%s devm_ioremap_resource fail\n", RTC_REG_NAME);
dev_dbg(&plat_dev->dev, "res = 0x%x, reg_base = 0x%lx\n",
sp_rtc->res->start, (unsigned long)sp_rtc->reg_base);