diff options
| author | Stephen Hemminger <stephen@networkplumber.org> | 2020-02-02 04:20:58 -0800 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2020-02-02 04:20:58 -0800 |
| commit | 8f9f2b9cdfbd1c7988542d81db1db854d48f2b0d (patch) | |
| tree | 2443b55ffa13eb3038e73fc2edaf6b46793ae535 | |
| parent | 5cdeb77cd6ec26f0a7103dfb21494a6a43903206 (diff) | |
| download | iproute2-8f9f2b9cdfbd1c7988542d81db1db854d48f2b0d.tar.gz | |
devlink: fix warning from unchecked write
Warning seen on Ubuntu
devlink.c: In function ‘cmd_dev_flash’:
devlink.c:3071:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
3071 | write(pipe_w, &err, sizeof(err));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 9b13cddfe268 ("devlink: implement flash status monitoring")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
| -rw-r--r-- | devlink/devlink.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/devlink/devlink.c b/devlink/devlink.c index 73ce98654..f9e58c1d7 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -3066,11 +3066,13 @@ static int cmd_dev_flash(struct dl *dl) /* In child, just execute the flash and pass returned * value through pipe once it is done. */ + int cc; + close(pipe_r); err = _mnlg_socket_send(dl->nlg, nlh); - write(pipe_w, &err, sizeof(err)); + cc = write(pipe_w, &err, sizeof(err)); close(pipe_w); - exit(0); + exit(cc != sizeof(err)); } close(pipe_w); |