aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2015-12-22 15:51:39 +0100
committerMark Brown <broonie@kernel.org>2015-12-23 00:23:01 +0000
commit34015f5e56c71bbdcf7189430ffb63ea67656a35 (patch)
tree7214384f3c119e6f9ee53495985e5155d3fca214
parent9bf5c3d11f1fbaf43399d189f05fb20ceb46ee5d (diff)
downloadsound-unstable-34015f5e56c71bbdcf7189430ffb63ea67656a35.tar.gz
ASoC: ac97: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/soc-ac97.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c
index ae563e379a724..733f5128eeff9 100644
--- a/sound/soc/soc-ac97.c
+++ b/sound/soc/soc-ac97.c
@@ -92,7 +92,7 @@ static int snd_soc_ac97_gpio_get(struct gpio_chip *chip, unsigned offset)
dev_dbg(codec->dev, "get gpio %d : %d\n", offset,
ret < 0 ? ret : ret & (1 << offset));
- return ret < 0 ? ret : ret & (1 << offset);
+ return ret < 0 ? ret : !!(ret & (1 << offset));
}
static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned offset,