diff options
author | Sasha Levin <sashal@kernel.org> | 2024-04-22 18:34:53 -0400 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2024-04-22 18:34:53 -0400 |
commit | 3dec8f7a596675511906c8d365b8783988290cbf (patch) | |
tree | 712f1ea3e43925e816e12ab45758b05f8b6d524a | |
parent | ba307a5410f4272d164235157b30053427b626a0 (diff) | |
download | stable-queue-3dec8f7a596675511906c8d365b8783988290cbf.tar.gz |
Fixes for 6.8
Signed-off-by: Sasha Levin <sashal@kernel.org>
14 files changed, 1262 insertions, 0 deletions
diff --git a/queue-6.8/block-propagate-partition-scanning-errors-to-the-blk.patch b/queue-6.8/block-propagate-partition-scanning-errors-to-the-blk.patch new file mode 100644 index 0000000000..b0ca9553bc --- /dev/null +++ b/queue-6.8/block-propagate-partition-scanning-errors-to-the-blk.patch @@ -0,0 +1,114 @@ +From 5ec255f346e530cf43481bc88b3fe891d51e9533 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Wed, 17 Apr 2024 16:47:43 +0200 +Subject: block: propagate partition scanning errors to the BLKRRPART ioctl + +From: Christoph Hellwig <hch@lst.de> + +[ Upstream commit 752863bddacab6b5c5164b1df8c8b2e3a175ee28 ] + +Commit 4601b4b130de ("block: reopen the device in blkdev_reread_part") +lost the propagation of I/O errors from the low-level read of the +partition table to the user space caller of the BLKRRPART. + +Apparently some user space relies on, so restore the propagation. This +isn't exactly pretty as other block device open calls explicitly do not +are about these errors, so add a new BLK_OPEN_STRICT_SCAN to opt into +the error propagation. + +Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part") +Reported-by: Saranya Muruganandam <saranyamohan@google.com> +Signed-off-by: Christoph Hellwig <hch@lst.de> +Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> +Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> +Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> +Link: https://lore.kernel.org/r/20240417144743.2277601-1-hch@lst.de +Signed-off-by: Jens Axboe <axboe@kernel.dk> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + block/bdev.c | 29 +++++++++++++++++++---------- + block/ioctl.c | 3 ++- + include/linux/blkdev.h | 2 ++ + 3 files changed, 23 insertions(+), 11 deletions(-) + +diff --git a/block/bdev.c b/block/bdev.c +index 678807bcd0034..2b0f97651a0a7 100644 +--- a/block/bdev.c ++++ b/block/bdev.c +@@ -639,6 +639,14 @@ static void blkdev_flush_mapping(struct block_device *bdev) + bdev_write_inode(bdev); + } + ++static void blkdev_put_whole(struct block_device *bdev) ++{ ++ if (atomic_dec_and_test(&bdev->bd_openers)) ++ blkdev_flush_mapping(bdev); ++ if (bdev->bd_disk->fops->release) ++ bdev->bd_disk->fops->release(bdev->bd_disk); ++} ++ + static int blkdev_get_whole(struct block_device *bdev, blk_mode_t mode) + { + struct gendisk *disk = bdev->bd_disk; +@@ -657,20 +665,21 @@ static int blkdev_get_whole(struct block_device *bdev, blk_mode_t mode) + + if (!atomic_read(&bdev->bd_openers)) + set_init_blocksize(bdev); +- if (test_bit(GD_NEED_PART_SCAN, &disk->state)) +- bdev_disk_changed(disk, false); + atomic_inc(&bdev->bd_openers); ++ if (test_bit(GD_NEED_PART_SCAN, &disk->state)) { ++ /* ++ * Only return scanning errors if we are called from contexts ++ * that explicitly want them, e.g. the BLKRRPART ioctl. ++ */ ++ ret = bdev_disk_changed(disk, false); ++ if (ret && (mode & BLK_OPEN_STRICT_SCAN)) { ++ blkdev_put_whole(bdev); ++ return ret; ++ } ++ } + return 0; + } + +-static void blkdev_put_whole(struct block_device *bdev) +-{ +- if (atomic_dec_and_test(&bdev->bd_openers)) +- blkdev_flush_mapping(bdev); +- if (bdev->bd_disk->fops->release) +- bdev->bd_disk->fops->release(bdev->bd_disk); +-} +- + static int blkdev_get_part(struct block_device *part, blk_mode_t mode) + { + struct gendisk *disk = part->bd_disk; +diff --git a/block/ioctl.c b/block/ioctl.c +index 438f79c564cfc..5f8c988239c68 100644 +--- a/block/ioctl.c ++++ b/block/ioctl.c +@@ -556,7 +556,8 @@ static int blkdev_common_ioctl(struct block_device *bdev, blk_mode_t mode, + return -EACCES; + if (bdev_is_partition(bdev)) + return -EINVAL; +- return disk_scan_partitions(bdev->bd_disk, mode); ++ return disk_scan_partitions(bdev->bd_disk, ++ mode | BLK_OPEN_STRICT_SCAN); + case BLKTRACESTART: + case BLKTRACESTOP: + case BLKTRACETEARDOWN: +diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h +index 99e4f5e722132..b43ca3b9d2a26 100644 +--- a/include/linux/blkdev.h ++++ b/include/linux/blkdev.h +@@ -126,6 +126,8 @@ typedef unsigned int __bitwise blk_mode_t; + #define BLK_OPEN_WRITE_IOCTL ((__force blk_mode_t)(1 << 4)) + /* open is exclusive wrt all other BLK_OPEN_WRITE opens to the device */ + #define BLK_OPEN_RESTRICT_WRITES ((__force blk_mode_t)(1 << 5)) ++/* return partition scanning errors */ ++#define BLK_OPEN_STRICT_SCAN ((__force blk_mode_t)(1 << 6)) + + struct gendisk { + /* +-- +2.43.0 + diff --git a/queue-6.8/clk-get-runtime-pm-before-walking-tree-during-disabl.patch b/queue-6.8/clk-get-runtime-pm-before-walking-tree-during-disabl.patch new file mode 100644 index 0000000000..424bbf8248 --- /dev/null +++ b/queue-6.8/clk-get-runtime-pm-before-walking-tree-during-disabl.patch @@ -0,0 +1,344 @@ +From 80ddbead474606d3124c164a92831b5b966aeee9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Mon, 25 Mar 2024 11:41:58 -0700 +Subject: clk: Get runtime PM before walking tree during disable_unused + +From: Stephen Boyd <sboyd@kernel.org> + +[ Upstream commit e581cf5d216289ef292d1a4036d53ce90e122469 ] + +Doug reported [1] the following hung task: + + INFO: task swapper/0:1 blocked for more than 122 seconds. + Not tainted 5.15.149-21875-gf795ebc40eb8 #1 + "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. + task:swapper/0 state:D stack: 0 pid: 1 ppid: 0 flags:0x00000008 + Call trace: + __switch_to+0xf4/0x1f4 + __schedule+0x418/0xb80 + schedule+0x5c/0x10c + rpm_resume+0xe0/0x52c + rpm_resume+0x178/0x52c + __pm_runtime_resume+0x58/0x98 + clk_pm_runtime_get+0x30/0xb0 + clk_disable_unused_subtree+0x58/0x208 + clk_disable_unused_subtree+0x38/0x208 + clk_disable_unused_subtree+0x38/0x208 + clk_disable_unused_subtree+0x38/0x208 + clk_disable_unused_subtree+0x38/0x208 + clk_disable_unused+0x4c/0xe4 + do_one_initcall+0xcc/0x2d8 + do_initcall_level+0xa4/0x148 + do_initcalls+0x5c/0x9c + do_basic_setup+0x24/0x30 + kernel_init_freeable+0xec/0x164 + kernel_init+0x28/0x120 + ret_from_fork+0x10/0x20 + INFO: task kworker/u16:0:9 blocked for more than 122 seconds. + Not tainted 5.15.149-21875-gf795ebc40eb8 #1 + "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. + task:kworker/u16:0 state:D stack: 0 pid: 9 ppid: 2 flags:0x00000008 + Workqueue: events_unbound deferred_probe_work_func + Call trace: + __switch_to+0xf4/0x1f4 + __schedule+0x418/0xb80 + schedule+0x5c/0x10c + schedule_preempt_disabled+0x2c/0x48 + __mutex_lock+0x238/0x488 + __mutex_lock_slowpath+0x1c/0x28 + mutex_lock+0x50/0x74 + clk_prepare_lock+0x7c/0x9c + clk_core_prepare_lock+0x20/0x44 + clk_prepare+0x24/0x30 + clk_bulk_prepare+0x40/0xb0 + mdss_runtime_resume+0x54/0x1c8 + pm_generic_runtime_resume+0x30/0x44 + __genpd_runtime_resume+0x68/0x7c + genpd_runtime_resume+0x108/0x1f4 + __rpm_callback+0x84/0x144 + rpm_callback+0x30/0x88 + rpm_resume+0x1f4/0x52c + rpm_resume+0x178/0x52c + __pm_runtime_resume+0x58/0x98 + __device_attach+0xe0/0x170 + device_initial_probe+0x1c/0x28 + bus_probe_device+0x3c/0x9c + device_add+0x644/0x814 + mipi_dsi_device_register_full+0xe4/0x170 + devm_mipi_dsi_device_register_full+0x28/0x70 + ti_sn_bridge_probe+0x1dc/0x2c0 + auxiliary_bus_probe+0x4c/0x94 + really_probe+0xcc/0x2c8 + __driver_probe_device+0xa8/0x130 + driver_probe_device+0x48/0x110 + __device_attach_driver+0xa4/0xcc + bus_for_each_drv+0x8c/0xd8 + __device_attach+0xf8/0x170 + device_initial_probe+0x1c/0x28 + bus_probe_device+0x3c/0x9c + deferred_probe_work_func+0x9c/0xd8 + process_one_work+0x148/0x518 + worker_thread+0x138/0x350 + kthread+0x138/0x1e0 + ret_from_fork+0x10/0x20 + +The first thread is walking the clk tree and calling +clk_pm_runtime_get() to power on devices required to read the clk +hardware via struct clk_ops::is_enabled(). This thread holds the clk +prepare_lock, and is trying to runtime PM resume a device, when it finds +that the device is in the process of resuming so the thread schedule()s +away waiting for the device to finish resuming before continuing. The +second thread is runtime PM resuming the same device, but the runtime +resume callback is calling clk_prepare(), trying to grab the +prepare_lock waiting on the first thread. + +This is a classic ABBA deadlock. To properly fix the deadlock, we must +never runtime PM resume or suspend a device with the clk prepare_lock +held. Actually doing that is near impossible today because the global +prepare_lock would have to be dropped in the middle of the tree, the +device runtime PM resumed/suspended, and then the prepare_lock grabbed +again to ensure consistency of the clk tree topology. If anything +changes with the clk tree in the meantime, we've lost and will need to +start the operation all over again. + +Luckily, most of the time we're simply incrementing or decrementing the +runtime PM count on an active device, so we don't have the chance to +schedule away with the prepare_lock held. Let's fix this immediate +problem that can be triggered more easily by simply booting on Qualcomm +sc7180. + +Introduce a list of clk_core structures that have been registered, or +are in the process of being registered, that require runtime PM to +operate. Iterate this list and call clk_pm_runtime_get() on each of them +without holding the prepare_lock during clk_disable_unused(). This way +we can be certain that the runtime PM state of the devices will be +active and resumed so we can't schedule away while walking the clk tree +with the prepare_lock held. Similarly, call clk_pm_runtime_put() without +the prepare_lock held to properly drop the runtime PM reference. We +remove the calls to clk_pm_runtime_{get,put}() in this path because +they're superfluous now that we know the devices are runtime resumed. + +Reported-by: Douglas Anderson <dianders@chromium.org> +Closes: https://lore.kernel.org/all/20220922084322.RFC.2.I375b6b9e0a0a5348962f004beb3dafee6a12dfbb@changeid/ [1] +Closes: https://issuetracker.google.com/328070191 +Cc: Marek Szyprowski <m.szyprowski@samsung.com> +Cc: Ulf Hansson <ulf.hansson@linaro.org> +Cc: Krzysztof Kozlowski <krzk@kernel.org> +Fixes: 9a34b45397e5 ("clk: Add support for runtime PM") +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Link: https://lore.kernel.org/r/20240325184204.745706-5-sboyd@kernel.org +Reviewed-by: Douglas Anderson <dianders@chromium.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/clk.c | 117 +++++++++++++++++++++++++++++++++++++++++----- + 1 file changed, 105 insertions(+), 12 deletions(-) + +diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c +index d5a1e68ee20b7..7162b45da91f8 100644 +--- a/drivers/clk/clk.c ++++ b/drivers/clk/clk.c +@@ -37,6 +37,10 @@ static HLIST_HEAD(clk_root_list); + static HLIST_HEAD(clk_orphan_list); + static LIST_HEAD(clk_notifier_list); + ++/* List of registered clks that use runtime PM */ ++static HLIST_HEAD(clk_rpm_list); ++static DEFINE_MUTEX(clk_rpm_list_lock); ++ + static const struct hlist_head *all_lists[] = { + &clk_root_list, + &clk_orphan_list, +@@ -59,6 +63,7 @@ struct clk_core { + struct clk_hw *hw; + struct module *owner; + struct device *dev; ++ struct hlist_node rpm_node; + struct device_node *of_node; + struct clk_core *parent; + struct clk_parent_map *parents; +@@ -122,6 +127,89 @@ static void clk_pm_runtime_put(struct clk_core *core) + pm_runtime_put_sync(core->dev); + } + ++/** ++ * clk_pm_runtime_get_all() - Runtime "get" all clk provider devices ++ * ++ * Call clk_pm_runtime_get() on all runtime PM enabled clks in the clk tree so ++ * that disabling unused clks avoids a deadlock where a device is runtime PM ++ * resuming/suspending and the runtime PM callback is trying to grab the ++ * prepare_lock for something like clk_prepare_enable() while ++ * clk_disable_unused_subtree() holds the prepare_lock and is trying to runtime ++ * PM resume/suspend the device as well. ++ * ++ * Context: Acquires the 'clk_rpm_list_lock' and returns with the lock held on ++ * success. Otherwise the lock is released on failure. ++ * ++ * Return: 0 on success, negative errno otherwise. ++ */ ++static int clk_pm_runtime_get_all(void) ++{ ++ int ret; ++ struct clk_core *core, *failed; ++ ++ /* ++ * Grab the list lock to prevent any new clks from being registered ++ * or unregistered until clk_pm_runtime_put_all(). ++ */ ++ mutex_lock(&clk_rpm_list_lock); ++ ++ /* ++ * Runtime PM "get" all the devices that are needed for the clks ++ * currently registered. Do this without holding the prepare_lock, to ++ * avoid the deadlock. ++ */ ++ hlist_for_each_entry(core, &clk_rpm_list, rpm_node) { ++ ret = clk_pm_runtime_get(core); ++ if (ret) { ++ failed = core; ++ pr_err("clk: Failed to runtime PM get '%s' for clk '%s'\n", ++ dev_name(failed->dev), failed->name); ++ goto err; ++ } ++ } ++ ++ return 0; ++ ++err: ++ hlist_for_each_entry(core, &clk_rpm_list, rpm_node) { ++ if (core == failed) ++ break; ++ ++ clk_pm_runtime_put(core); ++ } ++ mutex_unlock(&clk_rpm_list_lock); ++ ++ return ret; ++} ++ ++/** ++ * clk_pm_runtime_put_all() - Runtime "put" all clk provider devices ++ * ++ * Put the runtime PM references taken in clk_pm_runtime_get_all() and release ++ * the 'clk_rpm_list_lock'. ++ */ ++static void clk_pm_runtime_put_all(void) ++{ ++ struct clk_core *core; ++ ++ hlist_for_each_entry(core, &clk_rpm_list, rpm_node) ++ clk_pm_runtime_put(core); ++ mutex_unlock(&clk_rpm_list_lock); ++} ++ ++static void clk_pm_runtime_init(struct clk_core *core) ++{ ++ struct device *dev = core->dev; ++ ++ if (dev && pm_runtime_enabled(dev)) { ++ core->rpm_enabled = true; ++ ++ mutex_lock(&clk_rpm_list_lock); ++ hlist_add_head(&core->rpm_node, &clk_rpm_list); ++ mutex_unlock(&clk_rpm_list_lock); ++ } ++} ++ + /*** locking ***/ + static void clk_prepare_lock(void) + { +@@ -1362,9 +1450,6 @@ static void __init clk_unprepare_unused_subtree(struct clk_core *core) + if (core->flags & CLK_IGNORE_UNUSED) + return; + +- if (clk_pm_runtime_get(core)) +- return; +- + if (clk_core_is_prepared(core)) { + trace_clk_unprepare(core); + if (core->ops->unprepare_unused) +@@ -1373,8 +1458,6 @@ static void __init clk_unprepare_unused_subtree(struct clk_core *core) + core->ops->unprepare(core->hw); + trace_clk_unprepare_complete(core); + } +- +- clk_pm_runtime_put(core); + } + + static void __init clk_disable_unused_subtree(struct clk_core *core) +@@ -1390,9 +1473,6 @@ static void __init clk_disable_unused_subtree(struct clk_core *core) + if (core->flags & CLK_OPS_PARENT_ENABLE) + clk_core_prepare_enable(core->parent); + +- if (clk_pm_runtime_get(core)) +- goto unprepare_out; +- + flags = clk_enable_lock(); + + if (core->enable_count) +@@ -1417,8 +1497,6 @@ static void __init clk_disable_unused_subtree(struct clk_core *core) + + unlock_out: + clk_enable_unlock(flags); +- clk_pm_runtime_put(core); +-unprepare_out: + if (core->flags & CLK_OPS_PARENT_ENABLE) + clk_core_disable_unprepare(core->parent); + } +@@ -1434,6 +1512,7 @@ __setup("clk_ignore_unused", clk_ignore_unused_setup); + static int __init clk_disable_unused(void) + { + struct clk_core *core; ++ int ret; + + if (clk_ignore_unused) { + pr_warn("clk: Not disabling unused clocks\n"); +@@ -1442,6 +1521,13 @@ static int __init clk_disable_unused(void) + + pr_info("clk: Disabling unused clocks\n"); + ++ ret = clk_pm_runtime_get_all(); ++ if (ret) ++ return ret; ++ /* ++ * Grab the prepare lock to keep the clk topology stable while iterating ++ * over clks. ++ */ + clk_prepare_lock(); + + hlist_for_each_entry(core, &clk_root_list, child_node) +@@ -1458,6 +1544,8 @@ static int __init clk_disable_unused(void) + + clk_prepare_unlock(); + ++ clk_pm_runtime_put_all(); ++ + return 0; + } + late_initcall_sync(clk_disable_unused); +@@ -4195,6 +4283,12 @@ static void __clk_release(struct kref *ref) + { + struct clk_core *core = container_of(ref, struct clk_core, ref); + ++ if (core->rpm_enabled) { ++ mutex_lock(&clk_rpm_list_lock); ++ hlist_del(&core->rpm_node); ++ mutex_unlock(&clk_rpm_list_lock); ++ } ++ + clk_core_free_parent_map(core); + kfree_const(core->name); + kfree(core); +@@ -4234,9 +4328,8 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) + } + core->ops = init->ops; + +- if (dev && pm_runtime_enabled(dev)) +- core->rpm_enabled = true; + core->dev = dev; ++ clk_pm_runtime_init(core); + core->of_node = np; + if (dev && dev->driver) + core->owner = dev->driver->owner; +-- +2.43.0 + diff --git a/queue-6.8/clk-get-runtime-pm-before-walking-tree-for-clk_summa.patch b/queue-6.8/clk-get-runtime-pm-before-walking-tree-for-clk_summa.patch new file mode 100644 index 0000000000..bd04b589aa --- /dev/null +++ b/queue-6.8/clk-get-runtime-pm-before-walking-tree-for-clk_summa.patch @@ -0,0 +1,95 @@ +From 405830864e3edefd808136161d790758778fee7e Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Mon, 25 Mar 2024 11:41:59 -0700 +Subject: clk: Get runtime PM before walking tree for clk_summary + +From: Stephen Boyd <sboyd@kernel.org> + +[ Upstream commit 9d1e795f754db1ac3344528b7af0b17b8146f321 ] + +Similar to the previous commit, we should make sure that all devices are +runtime resumed before printing the clk_summary through debugfs. Failure +to do so would result in a deadlock if the thread is resuming a device +to print clk state and that device is also runtime resuming in another +thread, e.g the screen is turning on and the display driver is starting +up. We remove the calls to clk_pm_runtime_{get,put}() in this path +because they're superfluous now that we know the devices are runtime +resumed. This also squashes a bug where the return value of +clk_pm_runtime_get() wasn't checked, leading to an RPM count underflow +on error paths. + +Fixes: 1bb294a7981c ("clk: Enable/Disable runtime PM for clk_summary") +Cc: Taniya Das <quic_tdas@quicinc.com> +Cc: Douglas Anderson <dianders@chromium.org> +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Link: https://lore.kernel.org/r/20240325184204.745706-6-sboyd@kernel.org +Reviewed-by: Douglas Anderson <dianders@chromium.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/clk.c | 14 ++++++++++++-- + 1 file changed, 12 insertions(+), 2 deletions(-) + +diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c +index 7162b45da91f8..cf1fc0edfdbca 100644 +--- a/drivers/clk/clk.c ++++ b/drivers/clk/clk.c +@@ -3321,9 +3321,7 @@ static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c, + { + struct clk_core *child; + +- clk_pm_runtime_get(c); + clk_summary_show_one(s, c, level); +- clk_pm_runtime_put(c); + + hlist_for_each_entry(child, &c->children, child_node) + clk_summary_show_subtree(s, child, level + 1); +@@ -3333,11 +3331,15 @@ static int clk_summary_show(struct seq_file *s, void *data) + { + struct clk_core *c; + struct hlist_head **lists = s->private; ++ int ret; + + seq_puts(s, " enable prepare protect duty hardware connection\n"); + seq_puts(s, " clock count count count rate accuracy phase cycle enable consumer id\n"); + seq_puts(s, "---------------------------------------------------------------------------------------------------------------------------------------------\n"); + ++ ret = clk_pm_runtime_get_all(); ++ if (ret) ++ return ret; + + clk_prepare_lock(); + +@@ -3346,6 +3348,7 @@ static int clk_summary_show(struct seq_file *s, void *data) + clk_summary_show_subtree(s, c, 0); + + clk_prepare_unlock(); ++ clk_pm_runtime_put_all(); + + return 0; + } +@@ -3393,8 +3396,14 @@ static int clk_dump_show(struct seq_file *s, void *data) + struct clk_core *c; + bool first_node = true; + struct hlist_head **lists = s->private; ++ int ret; ++ ++ ret = clk_pm_runtime_get_all(); ++ if (ret) ++ return ret; + + seq_putc(s, '{'); ++ + clk_prepare_lock(); + + for (; *lists; lists++) { +@@ -3407,6 +3416,7 @@ static int clk_dump_show(struct seq_file *s, void *data) + } + + clk_prepare_unlock(); ++ clk_pm_runtime_put_all(); + + seq_puts(s, "}\n"); + return 0; +-- +2.43.0 + diff --git a/queue-6.8/clk-initialize-struct-clk_core-kref-earlier.patch b/queue-6.8/clk-initialize-struct-clk_core-kref-earlier.patch new file mode 100644 index 0000000000..59da71002b --- /dev/null +++ b/queue-6.8/clk-initialize-struct-clk_core-kref-earlier.patch @@ -0,0 +1,98 @@ +From ef866446a1abc4d509ef5b3b1a2bcbf0ab7c7ff5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Mon, 25 Mar 2024 11:41:57 -0700 +Subject: clk: Initialize struct clk_core kref earlier + +From: Stephen Boyd <sboyd@kernel.org> + +[ Upstream commit 9d05ae531c2cff20d5d527f04e28d28e04379929 ] + +Initialize this kref once we allocate memory for the struct clk_core so +that we can reuse the release function to free any memory associated +with the structure. This mostly consolidates code, but also clarifies +that the kref lifetime exists once the container structure (struct +clk_core) is allocated instead of leaving it in a half-baked state for +most of __clk_core_init(). + +Reviewed-by: Douglas Anderson <dianders@chromium.org> +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Link: https://lore.kernel.org/r/20240325184204.745706-4-sboyd@kernel.org +Stable-dep-of: e581cf5d2162 ("clk: Get runtime PM before walking tree during disable_unused") +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/clk.c | 28 +++++++++++++--------------- + 1 file changed, 13 insertions(+), 15 deletions(-) + +diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c +index c6928dce50f23..d5a1e68ee20b7 100644 +--- a/drivers/clk/clk.c ++++ b/drivers/clk/clk.c +@@ -3962,8 +3962,6 @@ static int __clk_core_init(struct clk_core *core) + } + + clk_core_reparent_orphans_nolock(); +- +- kref_init(&core->ref); + out: + clk_pm_runtime_put(core); + unlock: +@@ -4192,6 +4190,16 @@ static void clk_core_free_parent_map(struct clk_core *core) + kfree(core->parents); + } + ++/* Free memory allocated for a struct clk_core */ ++static void __clk_release(struct kref *ref) ++{ ++ struct clk_core *core = container_of(ref, struct clk_core, ref); ++ ++ clk_core_free_parent_map(core); ++ kfree_const(core->name); ++ kfree(core); ++} ++ + static struct clk * + __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) + { +@@ -4212,6 +4220,8 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) + goto fail_out; + } + ++ kref_init(&core->ref); ++ + core->name = kstrdup_const(init->name, GFP_KERNEL); + if (!core->name) { + ret = -ENOMEM; +@@ -4266,12 +4276,10 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw) + hw->clk = NULL; + + fail_create_clk: +- clk_core_free_parent_map(core); + fail_parents: + fail_ops: +- kfree_const(core->name); + fail_name: +- kfree(core); ++ kref_put(&core->ref, __clk_release); + fail_out: + return ERR_PTR(ret); + } +@@ -4351,16 +4359,6 @@ int of_clk_hw_register(struct device_node *node, struct clk_hw *hw) + } + EXPORT_SYMBOL_GPL(of_clk_hw_register); + +-/* Free memory allocated for a clock. */ +-static void __clk_release(struct kref *ref) +-{ +- struct clk_core *core = container_of(ref, struct clk_core, ref); +- +- clk_core_free_parent_map(core); +- kfree_const(core->name); +- kfree(core); +-} +- + /* + * Empty clk_ops for unregistered clocks. These are used temporarily + * after clk_unregister() was called on a clock and until last clock +-- +2.43.0 + diff --git a/queue-6.8/clk-mediatek-do-a-runtime-pm-get-on-controllers-duri.patch b/queue-6.8/clk-mediatek-do-a-runtime-pm-get-on-controllers-duri.patch new file mode 100644 index 0000000000..0929b67dca --- /dev/null +++ b/queue-6.8/clk-mediatek-do-a-runtime-pm-get-on-controllers-duri.patch @@ -0,0 +1,95 @@ +From 2f00519ba50bd8c2b37ea75d909a9c28a54048ed Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Tue, 12 Mar 2024 19:51:55 +0800 +Subject: clk: mediatek: Do a runtime PM get on controllers during probe + +From: Pin-yen Lin <treapking@chromium.org> + +[ Upstream commit 2f7b1d8b5505efb0057cd1ab85fca206063ea4c3 ] + +mt8183-mfgcfg has a mutual dependency with genpd during the probing +stage, which leads to a deadlock in the following call stack: + +CPU0: genpd_lock --> clk_prepare_lock +genpd_power_off_work_fn() + genpd_lock() + generic_pm_domain::power_off() + clk_unprepare() + clk_prepare_lock() + +CPU1: clk_prepare_lock --> genpd_lock +clk_register() + __clk_core_init() + clk_prepare_lock() + clk_pm_runtime_get() + genpd_lock() + +Do a runtime PM get at the probe function to make sure clk_register() +won't acquire the genpd lock. Instead of only modifying mt8183-mfgcfg, +do this on all mediatek clock controller probings because we don't +believe this would cause any regression. + +Verified on MT8183 and MT8192 Chromebooks. + +Fixes: acddfc2c261b ("clk: mediatek: Add MT8183 clock support") +Signed-off-by: Pin-yen Lin <treapking@chromium.org> + +Link: https://lore.kernel.org/r/20240312115249.3341654-1-treapking@chromium.org +Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> +Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/mediatek/clk-mtk.c | 15 +++++++++++++++ + 1 file changed, 15 insertions(+) + +diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c +index 2e55368dc4d82..bd37ab4d1a9bb 100644 +--- a/drivers/clk/mediatek/clk-mtk.c ++++ b/drivers/clk/mediatek/clk-mtk.c +@@ -13,6 +13,7 @@ + #include <linux/of.h> + #include <linux/of_address.h> + #include <linux/platform_device.h> ++#include <linux/pm_runtime.h> + #include <linux/slab.h> + + #include "clk-mtk.h" +@@ -494,6 +495,16 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, + return IS_ERR(base) ? PTR_ERR(base) : -ENOMEM; + } + ++ ++ devm_pm_runtime_enable(&pdev->dev); ++ /* ++ * Do a pm_runtime_resume_and_get() to workaround a possible ++ * deadlock between clk_register() and the genpd framework. ++ */ ++ r = pm_runtime_resume_and_get(&pdev->dev); ++ if (r) ++ return r; ++ + /* Calculate how many clk_hw_onecell_data entries to allocate */ + num_clks = mcd->num_clks + mcd->num_composite_clks; + num_clks += mcd->num_fixed_clks + mcd->num_factor_clks; +@@ -574,6 +585,8 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, + goto unregister_clks; + } + ++ pm_runtime_put(&pdev->dev); ++ + return r; + + unregister_clks: +@@ -604,6 +617,8 @@ static int __mtk_clk_simple_probe(struct platform_device *pdev, + free_base: + if (mcd->shared_io && base) + iounmap(base); ++ ++ pm_runtime_put(&pdev->dev); + return r; + } + +-- +2.43.0 + diff --git a/queue-6.8/clk-mediatek-mt7988-infracfg-fix-clocks-for-2nd-pcie.patch b/queue-6.8/clk-mediatek-mt7988-infracfg-fix-clocks-for-2nd-pcie.patch new file mode 100644 index 0000000000..8e2fcf02d2 --- /dev/null +++ b/queue-6.8/clk-mediatek-mt7988-infracfg-fix-clocks-for-2nd-pcie.patch @@ -0,0 +1,45 @@ +From eed88b3e3d991ad9a4e231a4cf9556f5008f2394 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Wed, 13 Mar 2024 22:05:37 +0000 +Subject: clk: mediatek: mt7988-infracfg: fix clocks for 2nd PCIe port + +From: Daniel Golle <daniel@makrotopia.org> + +[ Upstream commit d3e8a91a848a5941e3c31ecebd6b2612b37e01a6 ] + +Due to what seems to be an undocumented oddity in MediaTek's MT7988 +SoC design the CLK_INFRA_PCIE_PERI_26M_CK_P2 clock requires +CLK_INFRA_PCIE_PERI_26M_CK_P3 to be enabled. + +This currently leads to PCIe port 2 not working in Linux. + +Reflect the apparent relationship in the clk driver to make sure PCIe +port 2 of the MT7988 SoC works. + +Fixes: 4b4719437d85f ("clk: mediatek: add drivers for MT7988 SoC") +Suggested-by: Sam Shih <sam.shih@mediatek.com> +Signed-off-by: Daniel Golle <daniel@makrotopia.org> +Link: https://lore.kernel.org/r/1da2506a51f970706bf4ec9509dd04e0471065e5.1710367453.git.daniel@makrotopia.org +Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/mediatek/clk-mt7988-infracfg.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/clk/mediatek/clk-mt7988-infracfg.c b/drivers/clk/mediatek/clk-mt7988-infracfg.c +index 8011ef278bea3..df02997c6b7c9 100644 +--- a/drivers/clk/mediatek/clk-mt7988-infracfg.c ++++ b/drivers/clk/mediatek/clk-mt7988-infracfg.c +@@ -152,7 +152,7 @@ static const struct mtk_gate infra_clks[] = { + GATE_INFRA0(CLK_INFRA_PCIE_PERI_26M_CK_P1, "infra_pcie_peri_ck_26m_ck_p1", + "csw_infra_f26m_sel", 8), + GATE_INFRA0(CLK_INFRA_PCIE_PERI_26M_CK_P2, "infra_pcie_peri_ck_26m_ck_p2", +- "csw_infra_f26m_sel", 9), ++ "infra_pcie_peri_ck_26m_ck_p3", 9), + GATE_INFRA0(CLK_INFRA_PCIE_PERI_26M_CK_P3, "infra_pcie_peri_ck_26m_ck_p3", + "csw_infra_f26m_sel", 10), + /* INFRA1 */ +-- +2.43.0 + diff --git a/queue-6.8/clk-remove-prepare_lock-hold-assertion-in-__clk_rele.patch b/queue-6.8/clk-remove-prepare_lock-hold-assertion-in-__clk_rele.patch new file mode 100644 index 0000000000..c241e2ae92 --- /dev/null +++ b/queue-6.8/clk-remove-prepare_lock-hold-assertion-in-__clk_rele.patch @@ -0,0 +1,44 @@ +From 6eb5ffd8065c1e013f68bc694055e1d8b2eb8e60 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Mon, 25 Mar 2024 11:41:55 -0700 +Subject: clk: Remove prepare_lock hold assertion in __clk_release() + +From: Stephen Boyd <sboyd@kernel.org> + +[ Upstream commit 8358a76cfb47c9a5af627a0c4e7168aa14fa25f6 ] + +Removing this assertion lets us move the kref_put() call outside the +prepare_lock section. We don't need to hold the prepare_lock here to +free memory and destroy the clk_core structure. We've already unlinked +the clk from the clk tree and by the time the release function runs +nothing holds a reference to the clk_core anymore so anything with the +pointer can't access the memory that's being freed anyway. Way back in +commit 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of +prepare_lock") we didn't need to have this assertion either. + +Fixes: 496eadf821c2 ("clk: Use lockdep asserts to find missing hold of prepare_lock") +Cc: Krzysztof Kozlowski <krzk@kernel.org> +Reviewed-by: Douglas Anderson <dianders@chromium.org> +Signed-off-by: Stephen Boyd <sboyd@kernel.org> +Link: https://lore.kernel.org/r/20240325184204.745706-2-sboyd@kernel.org +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/clk/clk.c | 2 -- + 1 file changed, 2 deletions(-) + +diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c +index 20c4b28fed061..c6928dce50f23 100644 +--- a/drivers/clk/clk.c ++++ b/drivers/clk/clk.c +@@ -4356,8 +4356,6 @@ static void __clk_release(struct kref *ref) + { + struct clk_core *core = container_of(ref, struct clk_core, ref); + +- lockdep_assert_held(&prepare_lock); +- + clk_core_free_parent_map(core); + kfree_const(core->name); + kfree(core); +-- +2.43.0 + diff --git a/queue-6.8/interconnect-don-t-access-req_list-while-it-s-being-.patch b/queue-6.8/interconnect-don-t-access-req_list-while-it-s-being-.patch new file mode 100644 index 0000000000..39202d789b --- /dev/null +++ b/queue-6.8/interconnect-don-t-access-req_list-while-it-s-being-.patch @@ -0,0 +1,106 @@ +From 3a1db47ad4a78b4c8f3c0665c6e7fca4f271c003 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Tue, 5 Mar 2024 14:56:52 -0800 +Subject: interconnect: Don't access req_list while it's being manipulated + +From: Mike Tipton <quic_mdtipton@quicinc.com> + +[ Upstream commit de1bf25b6d771abdb52d43546cf57ad775fb68a1 ] + +The icc_lock mutex was split into separate icc_lock and icc_bw_lock +mutexes in [1] to avoid lockdep splats. However, this didn't adequately +protect access to icc_node::req_list. + +The icc_set_bw() function will eventually iterate over req_list while +only holding icc_bw_lock, but req_list can be modified while only +holding icc_lock. This causes races between icc_set_bw(), of_icc_get(), +and icc_put(). + +Example A: + + CPU0 CPU1 + ---- ---- + icc_set_bw(path_a) + mutex_lock(&icc_bw_lock); + icc_put(path_b) + mutex_lock(&icc_lock); + aggregate_requests() + hlist_for_each_entry(r, ... + hlist_del(... + <r = invalid pointer> + +Example B: + + CPU0 CPU1 + ---- ---- + icc_set_bw(path_a) + mutex_lock(&icc_bw_lock); + path_b = of_icc_get() + of_icc_get_by_index() + mutex_lock(&icc_lock); + path_find() + path_init() + aggregate_requests() + hlist_for_each_entry(r, ... + hlist_add_head(... + <r = invalid pointer> + +Fix this by ensuring icc_bw_lock is always held before manipulating +icc_node::req_list. The additional places icc_bw_lock is held don't +perform any memory allocations, so we should still be safe from the +original lockdep splats that motivated the separate locks. + +[1] commit af42269c3523 ("interconnect: Fix locking for runpm vs reclaim") + +Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com> +Fixes: af42269c3523 ("interconnect: Fix locking for runpm vs reclaim") +Reviewed-by: Rob Clark <robdclark@chromium.org> +Link: https://lore.kernel.org/r/20240305225652.22872-1-quic_mdtipton@quicinc.com +Signed-off-by: Georgi Djakov <djakov@kernel.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/interconnect/core.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c +index 50bac2d79d9b5..68edb07d4443e 100644 +--- a/drivers/interconnect/core.c ++++ b/drivers/interconnect/core.c +@@ -176,6 +176,8 @@ static struct icc_path *path_init(struct device *dev, struct icc_node *dst, + + path->num_nodes = num_nodes; + ++ mutex_lock(&icc_bw_lock); ++ + for (i = num_nodes - 1; i >= 0; i--) { + node->provider->users++; + hlist_add_head(&path->reqs[i].req_node, &node->req_list); +@@ -186,6 +188,8 @@ static struct icc_path *path_init(struct device *dev, struct icc_node *dst, + node = node->reverse; + } + ++ mutex_unlock(&icc_bw_lock); ++ + return path; + } + +@@ -792,12 +796,16 @@ void icc_put(struct icc_path *path) + pr_err("%s: error (%d)\n", __func__, ret); + + mutex_lock(&icc_lock); ++ mutex_lock(&icc_bw_lock); ++ + for (i = 0; i < path->num_nodes; i++) { + node = path->reqs[i].node; + hlist_del(&path->reqs[i].req_node); + if (!WARN_ON(!node->provider->users)) + node->provider->users--; + } ++ ++ mutex_unlock(&icc_bw_lock); + mutex_unlock(&icc_lock); + + kfree_const(path->name); +-- +2.43.0 + diff --git a/queue-6.8/interconnect-qcom-x1e80100-remove-inexistent-acv_per.patch b/queue-6.8/interconnect-qcom-x1e80100-remove-inexistent-acv_per.patch new file mode 100644 index 0000000000..666fd3f789 --- /dev/null +++ b/queue-6.8/interconnect-qcom-x1e80100-remove-inexistent-acv_per.patch @@ -0,0 +1,95 @@ +From f9d6b4bb5de52489735a9c001a80537ad308d979 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Sat, 2 Mar 2024 03:22:49 +0100 +Subject: interconnect: qcom: x1e80100: Remove inexistent ACV_PERF BCM + +From: Konrad Dybcio <konrad.dybcio@linaro.org> + +[ Upstream commit 59097a2a5ecadb0f025232c665fd11c8ae1e1f58 ] + +Booting the kernel on X1E results in a message like: + +[ 2.561524] qnoc-x1e80100 interconnect-0: ACV_PERF could not find RPMh address + +And indeed, taking a look at cmd-db, no such BCM exists. Remove it. + +Fixes: 9f196772841e ("interconnect: qcom: Add X1E80100 interconnect provider driver") +Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> +Reviewed-by: Mike Tipton <quic_mdtipton@quicinc.com> +Link: https://lore.kernel.org/r/20240302-topic-faux_bcm_x1e-v1-1-c40fab7c4bc5@linaro.org +Signed-off-by: Georgi Djakov <djakov@kernel.org> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/interconnect/qcom/x1e80100.c | 26 -------------------------- + 1 file changed, 26 deletions(-) + +diff --git a/drivers/interconnect/qcom/x1e80100.c b/drivers/interconnect/qcom/x1e80100.c +index cbaf4f9c41be6..06f0a6d6cbbc0 100644 +--- a/drivers/interconnect/qcom/x1e80100.c ++++ b/drivers/interconnect/qcom/x1e80100.c +@@ -116,15 +116,6 @@ static struct qcom_icc_node xm_sdc2 = { + .links = { X1E80100_SLAVE_A2NOC_SNOC }, + }; + +-static struct qcom_icc_node ddr_perf_mode_master = { +- .name = "ddr_perf_mode_master", +- .id = X1E80100_MASTER_DDR_PERF_MODE, +- .channels = 1, +- .buswidth = 4, +- .num_links = 1, +- .links = { X1E80100_SLAVE_DDR_PERF_MODE }, +-}; +- + static struct qcom_icc_node qup0_core_master = { + .name = "qup0_core_master", + .id = X1E80100_MASTER_QUP_CORE_0, +@@ -832,14 +823,6 @@ static struct qcom_icc_node qns_a2noc_snoc = { + .links = { X1E80100_MASTER_A2NOC_SNOC }, + }; + +-static struct qcom_icc_node ddr_perf_mode_slave = { +- .name = "ddr_perf_mode_slave", +- .id = X1E80100_SLAVE_DDR_PERF_MODE, +- .channels = 1, +- .buswidth = 4, +- .num_links = 0, +-}; +- + static struct qcom_icc_node qup0_core_slave = { + .name = "qup0_core_slave", + .id = X1E80100_SLAVE_QUP_CORE_0, +@@ -1591,12 +1574,6 @@ static struct qcom_icc_bcm bcm_acv = { + .nodes = { &ebi }, + }; + +-static struct qcom_icc_bcm bcm_acv_perf = { +- .name = "ACV_PERF", +- .num_nodes = 1, +- .nodes = { &ddr_perf_mode_slave }, +-}; +- + static struct qcom_icc_bcm bcm_ce0 = { + .name = "CE0", + .num_nodes = 1, +@@ -1863,18 +1840,15 @@ static const struct qcom_icc_desc x1e80100_aggre2_noc = { + }; + + static struct qcom_icc_bcm * const clk_virt_bcms[] = { +- &bcm_acv_perf, + &bcm_qup0, + &bcm_qup1, + &bcm_qup2, + }; + + static struct qcom_icc_node * const clk_virt_nodes[] = { +- [MASTER_DDR_PERF_MODE] = &ddr_perf_mode_master, + [MASTER_QUP_CORE_0] = &qup0_core_master, + [MASTER_QUP_CORE_1] = &qup1_core_master, + [MASTER_QUP_CORE_2] = &qup2_core_master, +- [SLAVE_DDR_PERF_MODE] = &ddr_perf_mode_slave, + [SLAVE_QUP_CORE_0] = &qup0_core_slave, + [SLAVE_QUP_CORE_1] = &qup1_core_slave, + [SLAVE_QUP_CORE_2] = &qup2_core_slave, +-- +2.43.0 + diff --git a/queue-6.8/platform-x86-amd-pmc-extend-framework-13-quirk-to-mo.patch b/queue-6.8/platform-x86-amd-pmc-extend-framework-13-quirk-to-mo.patch new file mode 100644 index 0000000000..7171464639 --- /dev/null +++ b/queue-6.8/platform-x86-amd-pmc-extend-framework-13-quirk-to-mo.patch @@ -0,0 +1,51 @@ +From 129be8a2facbeec943bb89edad76cf76657399f8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Wed, 10 Apr 2024 09:10:46 -0500 +Subject: platform/x86/amd/pmc: Extend Framework 13 quirk to more BIOSes +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Mario Limonciello <mario.limonciello@amd.com> + +[ Upstream commit f609e7b1b49e4d15cf107d2069673ee63860c398 ] + +BIOS 03.05 still hasn't fixed the spurious IRQ1 issue. As it's still +being worked on there is still a possibility that it won't need to +apply to future BIOS releases. + +Add a quirk for BIOS 03.05 as well. + +Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> +Reviewed-by: Hans de Goede <hdegoede@redhat.com> +Link: https://lore.kernel.org/r/20240410141046.433-1-mario.limonciello@amd.com +Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> +Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++ + 1 file changed, 9 insertions(+) + +diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c +index b456370166b6b..b4f49720c87f6 100644 +--- a/drivers/platform/x86/amd/pmc/pmc-quirks.c ++++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c +@@ -208,6 +208,15 @@ static const struct dmi_system_id fwbug_list[] = { + DMI_MATCH(DMI_BIOS_VERSION, "03.03"), + } + }, ++ { ++ .ident = "Framework Laptop 13 (Phoenix)", ++ .driver_data = &quirk_spurious_8042, ++ .matches = { ++ DMI_MATCH(DMI_SYS_VENDOR, "Framework"), ++ DMI_MATCH(DMI_PRODUCT_NAME, "Laptop 13 (AMD Ryzen 7040Series)"), ++ DMI_MATCH(DMI_BIOS_VERSION, "03.05"), ++ } ++ }, + {} + }; + +-- +2.43.0 + diff --git a/queue-6.8/selftests-powerpc-papr-vpd-fix-missing-variable-init.patch b/queue-6.8/selftests-powerpc-papr-vpd-fix-missing-variable-init.patch new file mode 100644 index 0000000000..b6ade0bea9 --- /dev/null +++ b/queue-6.8/selftests-powerpc-papr-vpd-fix-missing-variable-init.patch @@ -0,0 +1,40 @@ +From 0b0f5e7704024ddecdfed5758ddaf521b7d7d8e8 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Thu, 4 Apr 2024 17:02:09 -0500 +Subject: selftests/powerpc/papr-vpd: Fix missing variable initialization + +From: Nathan Lynch <nathanl@linux.ibm.com> + +[ Upstream commit 210cfef579260ed6c3b700e7baeae51a5e183f43 ] + +The "close handle without consuming VPD" testcase has inconsistent +results because it fails to initialize the location code object it +passes to ioctl() to create a VPD handle. Initialize the location code +to the empty string as intended. + +Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com> +Fixes: 9118c5d32bdd ("powerpc/selftests: Add test for papr-vpd") +Reported-by: Geetika Moolchandani <geetika@linux.ibm.com> +Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> +Link: https://msgid.link/20240404-papr-vpd-test-uninit-lc-v2-1-37bff46c65a5@linux.ibm.com +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c +index 505294da1b9fb..d6f99eb9be659 100644 +--- a/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c ++++ b/tools/testing/selftests/powerpc/papr_vpd/papr_vpd.c +@@ -154,7 +154,7 @@ static int dev_papr_vpd_null_handle(void) + static int papr_vpd_close_handle_without_reading(void) + { + const int devfd = open(DEVPATH, O_RDONLY); +- struct papr_location_code lc; ++ struct papr_location_code lc = { .str = "", }; + int fd; + + SKIP_IF_MSG(devfd < 0 && errno == ENOENT, +-- +2.43.0 + diff --git a/queue-6.8/series b/queue-6.8/series index ed55776af7..ffbaaaa1f9 100644 --- a/queue-6.8/series +++ b/queue-6.8/series @@ -70,3 +70,16 @@ drm-panel-visionox-rm69299-don-t-unregister-dsi-devi.patch drm-radeon-make-fstrict-flex-arrays-3-happy.patch alsa-hda-realtek-fix-volumn-control-of-thinkbook-16p.patch thermal-debugfs-add-missing-count-increment-to-therm.patch +platform-x86-amd-pmc-extend-framework-13-quirk-to-mo.patch +interconnect-qcom-x1e80100-remove-inexistent-acv_per.patch +interconnect-don-t-access-req_list-while-it-s-being-.patch +clk-remove-prepare_lock-hold-assertion-in-__clk_rele.patch +clk-initialize-struct-clk_core-kref-earlier.patch +clk-get-runtime-pm-before-walking-tree-during-disabl.patch +clk-get-runtime-pm-before-walking-tree-for-clk_summa.patch +clk-mediatek-do-a-runtime-pm-get-on-controllers-duri.patch +clk-mediatek-mt7988-infracfg-fix-clocks-for-2nd-pcie.patch +selftests-powerpc-papr-vpd-fix-missing-variable-init.patch +x86-bugs-fix-bhi-retpoline-check.patch +x86-cpufeatures-fix-dependencies-for-gfni-vaes-and-v.patch +block-propagate-partition-scanning-errors-to-the-blk.patch diff --git a/queue-6.8/x86-bugs-fix-bhi-retpoline-check.patch b/queue-6.8/x86-bugs-fix-bhi-retpoline-check.patch new file mode 100644 index 0000000000..1bd3c109df --- /dev/null +++ b/queue-6.8/x86-bugs-fix-bhi-retpoline-check.patch @@ -0,0 +1,63 @@ +From 7b540a4e816445860d85a807b6e38a7830e62150 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Fri, 12 Apr 2024 11:10:33 -0700 +Subject: x86/bugs: Fix BHI retpoline check + +From: Josh Poimboeuf <jpoimboe@kernel.org> + +[ Upstream commit 69129794d94c544810e68b2b4eaa7e44063f9bf2 ] + +Confusingly, X86_FEATURE_RETPOLINE doesn't mean retpolines are enabled, +as it also includes the original "AMD retpoline" which isn't a retpoline +at all. + +Also replace cpu_feature_enabled() with boot_cpu_has() because this is +before alternatives are patched and cpu_feature_enabled()'s fallback +path is slower than plain old boot_cpu_has(). + +Fixes: ec9404e40e8f ("x86/bhi: Add BHI mitigation knob") +Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> +Signed-off-by: Ingo Molnar <mingo@kernel.org> +Reviewed-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com> +Cc: Borislav Petkov <bp@alien8.de> +Cc: Linus Torvalds <torvalds@linux-foundation.org> +Link: https://lore.kernel.org/r/ad3807424a3953f0323c011a643405619f2a4927.1712944776.git.jpoimboe@kernel.org +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + arch/x86/kernel/cpu/bugs.c | 11 +++++++---- + 1 file changed, 7 insertions(+), 4 deletions(-) + +diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c +index cbc8c88144e47..e7ceee008bd09 100644 +--- a/arch/x86/kernel/cpu/bugs.c ++++ b/arch/x86/kernel/cpu/bugs.c +@@ -1651,7 +1651,8 @@ static void __init bhi_select_mitigation(void) + return; + + /* Retpoline mitigates against BHI unless the CPU has RRSBA behavior */ +- if (cpu_feature_enabled(X86_FEATURE_RETPOLINE)) { ++ if (boot_cpu_has(X86_FEATURE_RETPOLINE) && ++ !boot_cpu_has(X86_FEATURE_RETPOLINE_LFENCE)) { + spec_ctrl_disable_kernel_rrsba(); + if (rrsba_disabled) + return; +@@ -2803,11 +2804,13 @@ static const char *spectre_bhi_state(void) + { + if (!boot_cpu_has_bug(X86_BUG_BHI)) + return "; BHI: Not affected"; +- else if (boot_cpu_has(X86_FEATURE_CLEAR_BHB_HW)) ++ else if (boot_cpu_has(X86_FEATURE_CLEAR_BHB_HW)) + return "; BHI: BHI_DIS_S"; +- else if (boot_cpu_has(X86_FEATURE_CLEAR_BHB_LOOP)) ++ else if (boot_cpu_has(X86_FEATURE_CLEAR_BHB_LOOP)) + return "; BHI: SW loop, KVM: SW loop"; +- else if (boot_cpu_has(X86_FEATURE_RETPOLINE) && rrsba_disabled) ++ else if (boot_cpu_has(X86_FEATURE_RETPOLINE) && ++ !boot_cpu_has(X86_FEATURE_RETPOLINE_LFENCE) && ++ rrsba_disabled) + return "; BHI: Retpoline"; + else if (boot_cpu_has(X86_FEATURE_CLEAR_BHB_LOOP_ON_VMEXIT)) + return "; BHI: Vulnerable, KVM: SW loop"; +-- +2.43.0 + diff --git a/queue-6.8/x86-cpufeatures-fix-dependencies-for-gfni-vaes-and-v.patch b/queue-6.8/x86-cpufeatures-fix-dependencies-for-gfni-vaes-and-v.patch new file mode 100644 index 0000000000..de43567204 --- /dev/null +++ b/queue-6.8/x86-cpufeatures-fix-dependencies-for-gfni-vaes-and-v.patch @@ -0,0 +1,59 @@ +From b439e1ccdbad156fa24a785c39925babc88f22b1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin <sashal@kernel.org> +Date: Tue, 16 Apr 2024 23:04:34 -0700 +Subject: x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ + +From: Eric Biggers <ebiggers@google.com> + +[ Upstream commit 9543f6e26634537997b6e909c20911b7bf4876de ] + +Fix cpuid_deps[] to list the correct dependencies for GFNI, VAES, and +VPCLMULQDQ. These features don't depend on AVX512, and there exist CPUs +that support these features but not AVX512. GFNI actually doesn't even +depend on AVX. + +This prevents GFNI from being unnecessarily disabled if AVX is disabled +to mitigate the GDS vulnerability. + +This also prevents all three features from being unnecessarily disabled +if AVX512VL (or its dependency AVX512F) were to be disabled, but it +looks like there isn't any case where this happens anyway. + +Fixes: c128dbfa0f87 ("x86/cpufeatures: Enable new SSE/AVX/AVX512 CPU features") +Signed-off-by: Eric Biggers <ebiggers@google.com> +Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> +Acked-by: Dave Hansen <dave.hansen@linux.intel.com> +Link: https://lore.kernel.org/r/20240417060434.47101-1-ebiggers@kernel.org +Signed-off-by: Sasha Levin <sashal@kernel.org> +--- + arch/x86/kernel/cpu/cpuid-deps.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/arch/x86/kernel/cpu/cpuid-deps.c b/arch/x86/kernel/cpu/cpuid-deps.c +index e462c1d3800a6..6fb6d8a57ceca 100644 +--- a/arch/x86/kernel/cpu/cpuid-deps.c ++++ b/arch/x86/kernel/cpu/cpuid-deps.c +@@ -44,7 +44,10 @@ static const struct cpuid_dep cpuid_deps[] = { + { X86_FEATURE_F16C, X86_FEATURE_XMM2, }, + { X86_FEATURE_AES, X86_FEATURE_XMM2 }, + { X86_FEATURE_SHA_NI, X86_FEATURE_XMM2 }, ++ { X86_FEATURE_GFNI, X86_FEATURE_XMM2 }, + { X86_FEATURE_FMA, X86_FEATURE_AVX }, ++ { X86_FEATURE_VAES, X86_FEATURE_AVX }, ++ { X86_FEATURE_VPCLMULQDQ, X86_FEATURE_AVX }, + { X86_FEATURE_AVX2, X86_FEATURE_AVX, }, + { X86_FEATURE_AVX512F, X86_FEATURE_AVX, }, + { X86_FEATURE_AVX512IFMA, X86_FEATURE_AVX512F }, +@@ -56,9 +59,6 @@ static const struct cpuid_dep cpuid_deps[] = { + { X86_FEATURE_AVX512VL, X86_FEATURE_AVX512F }, + { X86_FEATURE_AVX512VBMI, X86_FEATURE_AVX512F }, + { X86_FEATURE_AVX512_VBMI2, X86_FEATURE_AVX512VL }, +- { X86_FEATURE_GFNI, X86_FEATURE_AVX512VL }, +- { X86_FEATURE_VAES, X86_FEATURE_AVX512VL }, +- { X86_FEATURE_VPCLMULQDQ, X86_FEATURE_AVX512VL }, + { X86_FEATURE_AVX512_VNNI, X86_FEATURE_AVX512VL }, + { X86_FEATURE_AVX512_BITALG, X86_FEATURE_AVX512VL }, + { X86_FEATURE_AVX512_4VNNIW, X86_FEATURE_AVX512F }, +-- +2.43.0 + |