diff options
| author | Dotan Barak <dotanb@dev.mellanox.com> | 2013-06-25 12:09:36 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-06-25 16:29:39 -0700 |
| commit | 618fad954b9becf095f1b52391af29f743ff4662 (patch) | |
| tree | 60570dc4a175db121cf2c099bd6404452cf77c07 | |
| parent | 42f1e9020e22d64d18292c6cb9182f4beeb43cad (diff) | |
| download | vxlan-next-618fad954b9becf095f1b52391af29f743ff4662.tar.gz | |
net/mlx4_core: Replace sscanf() with kstrtoint()
It is not safe to use sscanf.
Signed-off-by: Dotan Barak <dotanb@dev.mellanox.com>
Signed-off-by: Vladimir Sokolovsky <vlad@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 2f4a26039e8012..81e4529092a396 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -839,11 +839,11 @@ static ssize_t set_port_ib_mtu(struct device *dev, return -EINVAL; } - err = sscanf(buf, "%d", &mtu); - if (err > 0) + err = kstrtoint(buf, 0, &mtu); + if (!err) ibta_mtu = int_to_ibta_mtu(mtu); - if (err <= 0 || ibta_mtu < 0) { + if (err || ibta_mtu < 0) { mlx4_err(mdev, "%s is invalid IBTA mtu\n", buf); return -EINVAL; } |