aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRuliang Lin <u202112092@hust.edu.cn>2023-05-04 14:50:53 +0800
committerTakashi Iwai <tiwai@suse.de>2023-05-04 09:50:11 +0200
commit0d727e1856ef22dd9337199430258cb64cbbc658 (patch)
tree5f19147e2631b22013ddcde1796a4f4b8fb3e1c0
parent7501f472977df233d039d86c6981e0641708e1ca (diff)
downloadnext-fixes-0d727e1856ef22dd9337199430258cb64cbbc658.tar.gz
ALSA: caiaq: input: Add error handling for unsupported input methods in `snd_usb_caiaq_input_init`
Smatch complains that: snd_usb_caiaq_input_init() warn: missing error code 'ret' This patch adds a new case to handle the situation where the device does not support any input methods in the `snd_usb_caiaq_input_init` function. It returns an `-EINVAL` error code to indicate that no input methods are supported on the device. Fixes: 523f1dce3743 ("[ALSA] Add Native Instrument usb audio device support") Signed-off-by: Ruliang Lin <u202112092@hust.edu.cn> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> Acked-by: Daniel Mack <daniel@zonque.org> Link: https://lore.kernel.org/r/20230504065054.3309-1-u202112092@hust.edu.cn Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/usb/caiaq/input.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/usb/caiaq/input.c b/sound/usb/caiaq/input.c
index 1e2cf2f08eecdc..84f26dce7f5d03 100644
--- a/sound/usb/caiaq/input.c
+++ b/sound/usb/caiaq/input.c
@@ -804,6 +804,7 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev)
default:
/* no input methods supported on this device */
+ ret = -EINVAL;
goto exit_free_idev;
}