diff options
| author | Atul Gupta <atul.gupta@chelsio.com> | 2018-05-27 21:15:20 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-05-29 10:14:38 -0400 |
| commit | 53bcfb68c47dc0f2f1f6a2331dffdc9fbb98b116 (patch) | |
| tree | 0fbb963824af064c7ee96e4863a89de4f9234e2c | |
| parent | b7af47b33008c3558bd107de647be6f3e6c0dfc6 (diff) | |
| download | nfc-next-53bcfb68c47dc0f2f1f6a2331dffdc9fbb98b116.tar.gz | |
crypto: chtls: dereference null variable
skb dereferenced before check in sendpage
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Atul Gupta <atul.gupta@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/crypto/chelsio/chtls/chtls_io.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c index b6f2607f624e84..45107726308f4c 100644 --- a/drivers/crypto/chelsio/chtls/chtls_io.c +++ b/drivers/crypto/chelsio/chtls/chtls_io.c @@ -1230,9 +1230,8 @@ int chtls_sendpage(struct sock *sk, struct page *page, struct sk_buff *skb = skb_peek_tail(&csk->txq); int copy, i; - copy = mss - skb->len; if (!skb || (ULP_SKB_CB(skb)->flags & ULPCB_FLAG_NO_APPEND) || - copy <= 0) { + (copy = mss - skb->len) <= 0) { new_buf: if (!csk_mem_free(cdev, sk)) goto wait_for_sndbuf; |