diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-04-06 14:15:21 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-04-08 12:16:59 +0100 |
| commit | 1b808993e19447731e823b1313ee4e8da7fd92a0 (patch) | |
| tree | 04f0b87fc0587d5dd25399ceb3487936138d06d1 | |
| parent | 726e2c5929de841fdcef4e2bf995680688ae1b87 (diff) | |
| download | net-1b808993e19447731e823b1313ee4e8da7fd92a0.tar.gz | |
flow_dissector: fix false-positive __read_overflow2_field() warning
Bounds checking is unhappy that we try to copy both Ethernet
addresses but pass pointer to the first one. Luckily destination
address is the first field so pass the pointer to the entire header,
whatever.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/core/flow_dissector.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 9bd887610c18f4..6f7ec72016dcd5 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -1032,7 +1032,7 @@ bool __skb_flow_dissect(const struct net *net, key_eth_addrs = skb_flow_dissector_target(flow_dissector, FLOW_DISSECTOR_KEY_ETH_ADDRS, target_container); - memcpy(key_eth_addrs, ð->h_dest, sizeof(*key_eth_addrs)); + memcpy(key_eth_addrs, eth, sizeof(*key_eth_addrs)); } proto_again: |