aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKonstantin Ryabitsev <konstantin@linuxfoundation.org>2020-03-19 14:59:05 -0400
committerKonstantin Ryabitsev <konstantin@linuxfoundation.org>2020-03-19 14:59:05 -0400
commitd817474dfa35bc79809183920ae075d3ed727549 (patch)
tree1bde10560bb6bfc2e802196415ede04c50ecbea4
parent39dc465c2f0735ff590b56068523abdbcc89d800 (diff)
downloadkorg-helpers-d817474dfa35bc79809183920ae075d3ed727549.tar.gz
Don't set references on summary emails
Setting references to multiple thread parents is discouraged by the RFCs and causes unrelated messages to be grouped together by public-inbox. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
-rwxr-xr-xgit-patchwork-bot.py12
1 files changed, 6 insertions, 6 deletions
diff --git a/git-patchwork-bot.py b/git-patchwork-bot.py
index 5094f7f..1529a1c 100755
--- a/git-patchwork-bot.py
+++ b/git-patchwork-bot.py
@@ -535,7 +535,6 @@ def send_summary(serieslist, to_state, refname, config, nomail):
'%s (%s):\n'
) % (to_state, config['treename'], refname)
- references = list()
count = 0
for sdata in serieslist:
count += 1
@@ -544,10 +543,6 @@ def send_summary(serieslist, to_state, refname, config, nomail):
# If we have a cover letter, then the reference is the msgid of the cover letter,
# else the reference is the msgid of the first patch
patches = sdata.get('patches')
- if sdata.get('cover_letter'):
- references.append(sdata.get('cover_letter').get('msgid'))
- else:
- references.append(patches[0].get('msgid'))
submitter = sdata.get('submitter')
body += '\n'
@@ -560,6 +555,12 @@ def send_summary(serieslist, to_state, refname, config, nomail):
body += ' Submitter: %s <%s>\n' % (submitter.get('name'), submitter.get('email'))
body += ' Patchwork: %s\n' % sdata.get('web_url')
+ if sdata.get('cover_letter'):
+ link = sdata.get('cover_letter').get('msgid')
+ else:
+ link = patches[0].get('msgid')
+ body += ' Link: %s\n' % link
+
if len(patches) > 1:
body += ' Patches: %s\n' % patches[0].get('name')
for patch in patches[1:]:
@@ -577,7 +578,6 @@ def send_summary(serieslist, to_state, refname, config, nomail):
msg['From'] = Header(config['from'], 'utf-8')
msg['Message-Id'] = make_msgid('git-patchwork-summary')
msg['Date'] = formatdate(localtime=True)
- msg['References'] = Header(', '.join(references), 'utf-8')
targets = config['summaryto'].split(',')
msg['To'] = Header(', '.join(targets), 'utf-8')