diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2022-01-25 14:16:41 +0000 |
|---|---|---|
| committer | Mark Rutland <mark.rutland@arm.com> | 2022-01-27 15:51:45 +0000 |
| commit | 2dc972a278766c44167f664eeca50e50dff8c511 (patch) | |
| tree | b6a126634597e29bca7cfe76e6a706ea20537124 | |
| parent | 2dd9f3117d00b4d78e7a2e5309140b11f5f5ac07 (diff) | |
| download | boot-wrapper-aarch64-2dc972a278766c44167f664eeca50e50dff8c511.tar.gz | |
aarch64: correct SCTLR_EL1_KERNEL for AA32 kernels
Bits [31:0] of the AArch64 SCTLR_EL1 register are architecturally mapped
to bits [31:0] of the AArch32 SCTLR register. This means that any
individual bit always has the same value across the two registers.
Across the two registers, the same bit may have distinct meanings,
distinct RESx behaviour, and distinct reset behaviour. For example,
SCTLR_EL1[28] is nTLSMD, which we wich to initialize to 0b1, whereas
SCTLR[28] is TRE, which we wish to initialize to 0b0.
To avoid setting bits which we did not intend to, and in preparation for
configuring more AArch64 RES1 bits, this patch decouples the
SCTLR_EL1_KERNEL value used for AArch32 kernels from the SCTLR_EL1_RES1
definitions such that is does not inherit AArch64 SCTLR_EL1 bits which
would be problematic in the AArch32 SCTLR. For now we open-code a copy
of the bits defined in arch/aarch64/include/asm/cpu.h.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
| -rw-r--r-- | arch/aarch64/include/asm/cpu.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/arch/aarch64/include/asm/cpu.h b/arch/aarch64/include/asm/cpu.h index e3269b8..49d3f86 100644 --- a/arch/aarch64/include/asm/cpu.h +++ b/arch/aarch64/include/asm/cpu.h @@ -36,8 +36,15 @@ #define SCTLR_EL1_RES1 (3 << 28 | 3 << 22 | 1 << 11) #ifdef KERNEL_32 -/* 32-bit kernel decompressor uses CP15 barriers */ -#define SCTLR_EL1_KERNEL (SCTLR_EL1_RES1 | SCTLR_EL1_CP15BEN) +/* + * When booting a 32-bit kernel, EL1 uses AArch32 and registers which are + * architecturally mapped must be configured with the AArch32 layout. + * + * We copy the AArch32 definition of SCTLR_KERNEL here. + * + * TODO: restructure the headers to share a single definition. + */ +#define SCTLR_EL1_KERNEL (3 << 22 | 1 << 11 | 1 << 5 | 3 << 4) #define SPSR_KERNEL (SPSR_A | SPSR_I | SPSR_F | SPSR_HYP) #else #define SCTLR_EL1_KERNEL SCTLR_EL1_RES1 |